Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Sun, 09 Aug 2020 20:32:57 -0700
From:   Rajkumar Manoharan <rmanohar@codeaurora.org>
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     linux-wireless@vger.kernel.org,
        Johannes Berg <johannes.berg@intel.com>,
        linux-wireless-owner@vger.kernel.org
Subject: Re: [PATCH] nl80211: fix NL80211_ATTR_HE_6GHZ_CAPABILITY usage
In-Reply-To: <20200805153516.310cef625955.I0abc04dc8abb2c7c005c88ef8fa2d0e3c9fb95c4@changeid>
References: <20200805153516.310cef625955.I0abc04dc8abb2c7c005c88ef8fa2d0e3c9fb95c4@changeid>
Message-ID: <fc6a6a11da040dbb85cb7c41201b2736@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 2020-08-05 06:35, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
> 
> In nl80211_set_station(), we check NL80211_ATTR_HE_6GHZ_CAPABILITY
> and then use NL80211_ATTR_HE_CAPABILITY, which is clearly wrong.
> Fix this to use NL80211_ATTR_HE_6GHZ_CAPABILITY as well.
> 
> Fixes: 43e64bf301fd ("cfg80211: handle 6 GHz capability of new 
> station")
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
>  net/wireless/nl80211.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
> index 19281d0c8c9d..bfda09d24146 100644
> --- a/net/wireless/nl80211.c
> +++ b/net/wireless/nl80211.c
> @@ -6008,7 +6008,7 @@ static int nl80211_set_station(struct sk_buff
> *skb, struct genl_info *info)
> 
>  	if (info->attrs[NL80211_ATTR_HE_6GHZ_CAPABILITY])
>  		params.he_6ghz_capa =
> -			nla_data(info->attrs[NL80211_ATTR_HE_CAPABILITY]);
> +			nla_data(info->attrs[NL80211_ATTR_HE_6GHZ_CAPABILITY]);
> 
Thanks for the fix :). Must have overlooked.

-Rajkumar