Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@redhat.com>
To:     Felix Fietkau <nbd@nbd.name>, linux-wireless@vger.kernel.org
Cc:     johannes@sipsolutions.net
Subject: Re: [PATCH] mac80211: remove STA txq pending airtime underflow warning
In-Reply-To: <20200725084533.13829-1-nbd@nbd.name>
References: <20200725084533.13829-1-nbd@nbd.name>
Date:   Tue, 11 Aug 2020 11:31:16 +0200
Message-ID: <87a6z134wr.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Felix Fietkau <nbd@nbd.name> writes:

> This warning can trigger if there is a mismatch between frames that were
> sent with the sta pointer set vs tx status frames reported for the sta ad=
dress.
>
> This can happen due to race conditions on re-creating stations, or even
> in the case of .sta_add/remove being used instead of .sta_state, which ca=
n cause
> frames to be sent to a station that has not been uploaded yet.
>
> If there is an actual underflow issue, it should show up in the device ai=
rtime
> warning below, so it is better to remove this one.

Fair enough.

Acked-by: Toke H=C3=B8iland-J=C3=B8rgensen <toke@redhat.com>