Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp551294pxa; Wed, 12 Aug 2020 08:20:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx4OIp4ARHyWlSBWLVHw3F+w2GAi9bEU/dls13UEbsIuGk15BdbxAef2eDvoiDc5FTw9I/b X-Received: by 2002:aa7:da48:: with SMTP id w8mr365505eds.329.1597245636500; Wed, 12 Aug 2020 08:20:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597245636; cv=none; d=google.com; s=arc-20160816; b=V7oDm58/OiiLBMmpjLwSYxzeTPfmmiUR1qtZIMYxraHYpP519+DZ7s002EmSs2tV9n C+i/a2aqtNpbNvRoTb/i4lac2jRoWT3tFpQLlIMaPsSj2JAOj0Pkv/J2Ff/BraA27xy/ j0A3q9U1X75XLu53hxk1k92yNy20h54OGbrtWkLewp8mJioO+Blknk3WvC3kDdBVQkQM 0sKJn1Mtp3V9yLWFUGtizjMmg6xzEfLHnN1Jplw9WynqIa/i1U+ZxgS+MKptj4qmT4VL kOXcuoLsPyf/mNDUn9sp2TzoIuDW561YxhfY7fEGH8hfkwRkReis1cft0iUD2rRx587p iEkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:references:in-reply-to:subject:cc:to:from :dkim-signature; bh=j/6YCC8rF/n0jjkmOFgRfI6WFgYQisH5kto2Ia8JPo8=; b=LrM1OFrPvGehcsYJmqRmmOXLfFmeJltFdj6UQOuoF0Z67old7S434Z4EoEy3dLZpvL cCdfCuI2Ob5gEFSpITRyrCQbfHnI271lxe6ha6HHcb/BmMPwJgdI4qA8a9+YYv+Au3x/ s7bliLo9WqrvAEEte15Nq57Tj9i6uh12oPqX/Wy/i3yD5xFAria+lJCftrSeSSTmwOFS dPnbJEicIeY/CGhwFrBHsxV2918+Ce9xgykP6s1vr+r4ed3bzR1n+qs25FR843/FKk3g lVBSQn7BCJgerml0/FgjOWf+36OmjDjG7qCdyM3fZnLpRy9gshaezhJdZBZgyWRQUl5U QrBQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UfpMGj2D; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p9si1519678edh.42.2020.08.12.08.20.06; Wed, 12 Aug 2020 08:20:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UfpMGj2D; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726587AbgHLPT6 (ORCPT + 99 others); Wed, 12 Aug 2020 11:19:58 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:32299 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726492AbgHLPTz (ORCPT ); Wed, 12 Aug 2020 11:19:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1597245593; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j/6YCC8rF/n0jjkmOFgRfI6WFgYQisH5kto2Ia8JPo8=; b=UfpMGj2DYBJziavyqVYRH+36Z48POCYUbnbz5Bf4WdjUx133HjK+/VMPVg5rjkj+tXSLSn BKCYIzYt6Dyq6To6UVDdmXcy/tbhb06QtdR15D/l2MOrkVLdu/fUaZCXSWgubZi2TXykaL /RVvdNiKWLCp7gZuiYXTvGFnZmVk6Y0= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-136-suTHRt0nPxmQl5ILj8mQww-1; Wed, 12 Aug 2020 11:19:51 -0400 X-MC-Unique: suTHRt0nPxmQl5ILj8mQww-1 Received: by mail-wm1-f72.google.com with SMTP id f74so1000568wmf.1 for ; Wed, 12 Aug 2020 08:19:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=j/6YCC8rF/n0jjkmOFgRfI6WFgYQisH5kto2Ia8JPo8=; b=PETxO2seY/gmmpkPaqaGesZEkPjFSnEvwXyC+RxfPNFd3bv9Jqc4bjI1ZKyWvZ2n0r e7fE5ArFwqjL7S9UGSic6GWWmzc6II5nVhisCLl29qg4ANt6gmUQCSR2iJlp1c3L6cdt bJN7ishJovaY7ROGXiJnIgVUGsI35pwIVwdxgb9UEDzfpLU91ZzdLaeLj1kV+SDAlDlh O1a4JNZVhIljRzL8eWF/G4WCmGu9oCtuIa7I9EYBrDkhxl/kRi5axPnmXuG1WbKDOt1M TvblkJF+tQkGIFyDoEPbRbc+WSniW069XjOPgxM6fcni5OcbzRbTk6yzFajsurttOGYW ij3A== X-Gm-Message-State: AOAM533zD9QtrIP2eOK0Nu41jFdfUROEmjXzbZiX825dvrLO1pEn3em4 JTXqG+ZbT0O5cXQt86VRbUg7QsO2eyCHVRXEACwm3u2nCt15iAqCKtEJwVPjeKqt9EmpFOLrjVw k7GdCoOwIvqXmXTOFYLtAOi5FB+4= X-Received: by 2002:a1c:a787:: with SMTP id q129mr214040wme.77.1597245589862; Wed, 12 Aug 2020 08:19:49 -0700 (PDT) X-Received: by 2002:a1c:a787:: with SMTP id q129mr214026wme.77.1597245589670; Wed, 12 Aug 2020 08:19:49 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([45.145.92.2]) by smtp.gmail.com with ESMTPSA id r16sm5285140wrr.13.2020.08.12.08.19.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2020 08:19:49 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 16271182840; Wed, 12 Aug 2020 17:19:47 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Felix Fietkau , linux-wireless@vger.kernel.org Cc: kvalo@codeaurora.org Subject: Re: [PATCH 5.9] mt76: mt7915: use ieee80211_free_txskb to free tx skbs In-Reply-To: <20200812144943.91974-1-nbd@nbd.name> References: <20200812144943.91974-1-nbd@nbd.name> X-Clacks-Overhead: GNU Terry Pratchett Date: Wed, 12 Aug 2020 17:19:47 +0200 Message-ID: <878sejvqlo.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Felix Fietkau writes: > Using dev_kfree_skb for tx skbs breaks AQL. This worked until now only > by accident, because a mac80211 issue breaks AQL on drivers with firmware > rate control that report the rate via ieee80211_tx_status_ext as struct > rate_info. Ah, nice catch! Is it safe to assume that you also have a fix pending for the mac80211 issue you're talking about in the commit message? :) Acked-by: Toke H=C3=B8iland-J=C3=B8rgensen -Toke