Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp553072pxa; Wed, 12 Aug 2020 08:22:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyI/oaDejaevUZZdYHY0C8QZn1jPbLIg8Uo92WbyMwunVZb+xvaJTLDO15w3NAk3FZJosOF X-Received: by 2002:a17:906:3b18:: with SMTP id g24mr301796ejf.420.1597245767398; Wed, 12 Aug 2020 08:22:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597245767; cv=none; d=google.com; s=arc-20160816; b=U0PWkMuuMo3PkMcs50jq0nYvHU7bRfNJmsf0Na77MDZKYsDO4KX79LUBktomeIJw4t TvUqBX6MwV3B6C1zjiIrdJ6IRi8GAibK2+w58U9+4j2VjoLdOFYurDhvL3VLH9FGNx/t j+DzzFTa/0ldre4O7SN2aQkueeugo7BwsjTOCqwhZzM/2/O29A2vWdxqXwRYAAkWMaoG pdMbh10bNQAPRIzxr5ShDjFeh+7FR4pzEP5SAtbqPOVxp/O2XtyRcd809+os0mibC9m+ X+QThp5EHq4gqHXFyNu+tqcHDUpvJ2E06MDhd/2jRVnfhyUYQHCIgHlma8RskYbC16+b H23w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:dkim-signature; bh=OFhvZazAfxvwxE2vOozXHSXeH+qTGMvqb4RukNF8l3s=; b=xXUt6hiYZxSpcdwtQBOC0ChmJegZ69Vo16AJp7gxg23MifzJ4HHLYxrxj/qU1Zvaet sRZNh+1WU9A6zGdoRGuP5CT0v8xQCV7SwqJimOB7PMPpEhVnY3VFZ+mE10xfCKXVj2S8 5WCR9Nfrss699LqDOvxdBAS0Rtd2ohaX2iKu89tQdxU2NPNd9oYFm+Ptw9pxHacTtK1N H2K4Lwt32TtPn4dEcisyGsLDnKS6g51RPZ8OvkZPJKaqdi+qwnlUIwkc5Pu5R8d8X/i7 Zc3dYLbxjz34dBOYXGK03zorWVGStNuHG8h9HdAgQXKsMODteWlrvdysS8iL6DhElJNm fo8g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=LJVoqq2e; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bu20si1374182edb.537.2020.08.12.08.22.22; Wed, 12 Aug 2020 08:22:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=LJVoqq2e; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726510AbgHLPWI (ORCPT + 99 others); Wed, 12 Aug 2020 11:22:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726447AbgHLPWH (ORCPT ); Wed, 12 Aug 2020 11:22:07 -0400 Received: from nbd.name (nbd.name [IPv6:2a01:4f8:221:3d45::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F24F7C061383 for ; Wed, 12 Aug 2020 08:22:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=OFhvZazAfxvwxE2vOozXHSXeH+qTGMvqb4RukNF8l3s=; b=LJVoqq2e1JRNToBr0CH89ZJnNd AYJ6rMbn+PBXr2qkXzshEI6rGZj6U7o8Q9o0E8wCyKbtOiFM54Q3JKKMGyUlSga4wnZJDwscWjaa4 DavBFt5KfQV3JOIV92Zs8ZVTVk7Dx4CjfHcgpf7WrLRY/HbxkEG/RP5/NkqCgdSwFUjI=; Received: from p54ae996c.dip0.t-ipconnect.de ([84.174.153.108] helo=nf.local) by ds12 with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1k5sZp-0003kf-1P; Wed, 12 Aug 2020 17:22:05 +0200 Subject: Re: [PATCH 5.9] mt76: mt7915: use ieee80211_free_txskb to free tx skbs To: =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= , linux-wireless@vger.kernel.org Cc: kvalo@codeaurora.org References: <20200812144943.91974-1-nbd@nbd.name> <878sejvqlo.fsf@toke.dk> From: Felix Fietkau Autocrypt: addr=nbd@nbd.name; prefer-encrypt=mutual; keydata= xsDiBEah5CcRBADIY7pu4LIv3jBlyQ/2u87iIZGe6f0f8pyB4UjzfJNXhJb8JylYYRzIOSxh ExKsdLCnJqsG1PY1mqTtoG8sONpwsHr2oJ4itjcGHfn5NJSUGTbtbbxLro13tHkGFCoCr4Z5 Pv+XRgiANSpYlIigiMbOkide6wbggQK32tC20QxUIwCg4k6dtV/4kwEeiOUfErq00TVqIiEE AKcUi4taOuh/PQWx/Ujjl/P1LfJXqLKRPa8PwD4j2yjoc9l+7LptSxJThL9KSu6gtXQjcoR2 vCK0OeYJhgO4kYMI78h1TSaxmtImEAnjFPYJYVsxrhay92jisYc7z5R/76AaELfF6RCjjGeP wdalulG+erWju710Bif7E1yjYVWeA/9Wd1lsOmx6uwwYgNqoFtcAunDaMKi9xVQW18FsUusM TdRvTZLBpoUAy+MajAL+R73TwLq3LnKpIcCwftyQXK5pEDKq57OhxJVv1Q8XkA9Dn1SBOjNB l25vJDFAT9ntp9THeDD2fv15yk4EKpWhu4H00/YX8KkhFsrtUs69+vZQwc0cRmVsaXggRmll dGthdSA8bmJkQG5iZC5uYW1lPsJgBBMRAgAgBQJGoeQnAhsjBgsJCAcDAgQVAggDBBYCAwEC HgECF4AACgkQ130UHQKnbvXsvgCgjsAIIOsY7xZ8VcSm7NABpi91yTMAniMMmH7FRenEAYMa VrwYTIThkTlQzsFNBEah5FQQCACMIep/hTzgPZ9HbCTKm9xN4bZX0JjrqjFem1Nxf3MBM5vN CYGBn8F4sGIzPmLhl4xFeq3k5irVg/YvxSDbQN6NJv8o+tP6zsMeWX2JjtV0P4aDIN1pK2/w VxcicArw0VYdv2ZCarccFBgH2a6GjswqlCqVM3gNIMI8ikzenKcso8YErGGiKYeMEZLwHaxE Y7mTPuOTrWL8uWWRL5mVjhZEVvDez6em/OYvzBwbkhImrryF29e3Po2cfY2n7EKjjr3/141K DHBBdgXlPNfDwROnA5ugjjEBjwkwBQqPpDA7AYPvpHh5vLbZnVGu5CwG7NAsrb2isRmjYoqk wu++3117AAMFB/9S0Sj7qFFQcD4laADVsabTpNNpaV4wAgVTRHKV/kC9luItzwDnUcsZUPdQ f3MueRJ3jIHU0UmRBG3uQftqbZJj3ikhnfvyLmkCNe+/hXhPu9sGvXyi2D4vszICvc1KL4RD aLSrOsROx22eZ26KqcW4ny7+va2FnvjsZgI8h4sDmaLzKczVRIiLITiMpLFEU/VoSv0m1F4B FtRgoiyjFzigWG0MsTdAN6FJzGh4mWWGIlE7o5JraNhnTd+yTUIPtw3ym6l8P+gbvfoZida0 TspgwBWLnXQvP5EDvlZnNaKa/3oBes6z0QdaSOwZCRA3QSLHBwtgUsrT6RxRSweLrcabwkkE GBECAAkFAkah5FQCGwwACgkQ130UHQKnbvW2GgCfTKx80VvCR/PvsUlrvdOLsIgeRGAAn1ee RjMaxwtSdaCKMw3j33ZbsWS4 Message-ID: <635ffd81-e830-a60d-8580-f69526d5d230@nbd.name> Date: Wed, 12 Aug 2020 17:22:04 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <878sejvqlo.fsf@toke.dk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2020-08-12 17:19, Toke Høiland-Jørgensen wrote: > Felix Fietkau writes: > >> Using dev_kfree_skb for tx skbs breaks AQL. This worked until now only >> by accident, because a mac80211 issue breaks AQL on drivers with firmware >> rate control that report the rate via ieee80211_tx_status_ext as struct >> rate_info. > > Ah, nice catch! Is it safe to assume that you also have a fix pending > for the mac80211 issue you're talking about in the commit message? :) Sure, I will send it soon. - Felix