Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2187281pxa; Mon, 17 Aug 2020 03:24:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz7hR3zC5oh7ZAUnJI8Yy+s2Uc2dnTQErzdszu6UJ30ueNs6M+8R5aDGjgenJZ4RzlVE+Uc X-Received: by 2002:a17:906:2801:: with SMTP id r1mr13908998ejc.17.1597659858432; Mon, 17 Aug 2020 03:24:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597659858; cv=none; d=google.com; s=arc-20160816; b=Vd7EOfGxdarj6Gyc+sYHss7fln+zZT2z4LHH19Fi/7sQyULt3txfReLnLnESRXH1/Z xk0B97h7RuVJsRGRkCE+IHB3VboSTklN5y8yPnmqOWuMSWqyAT6sqEXtavB9rH2+6zMm NL9hdujslzYLeqx8exO2TrpuMFhgteTkucGEeHcXdEHjWHReqWJwekEjRjMvhtKE5qF6 ySJsaBxyLa1iwKlrom/2cAjgIx4GeW6KLxyy2NOqsjQe1xedSv693gnCp4m/TlYnM7vi v5kLC/z9PbffcXdBIp3GV5cgsTMjgTLhd9GebzfW0ryHHqQJvgp7YM8t0AOFjfkFt/qj c7ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature; bh=UHi/ozRmVDf+5fekjlpSZStl+2B7AhNxn2mgkOsi3Ew=; b=zq5GQ0QvDZjvTm3nTfpDmPBVWlGUggfEg1pfl585hLtQzfov/knsh2BlnWBJO/yWGu uuofGX6aVJHUS4uEgMf55CZqDgAfsWvczNKRa32giOkpeEQvmJz9z5TSpr/UaLqdLg7p 9miY1DFj8+dDvtSTxRkdslDTg3EDVHA2gkYxfq9mNhKfAckcqa+x+fDn55rq4c5OYWw1 zHxwLkhiJh+FKEpL5SwuWasFZZb6mPkhi+r056Cq0YOjYt34/DY6vGOI8F5fRPReoIfM njczsNzHgYJUx6duk7kDsUnHAm8c0sUjQmUI7Jvq3TfzSHVyml3ekRfFhWSw7pnGnnEw PIKA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=MgrXubLA; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f1si10494261edw.580.2020.08.17.03.23.54; Mon, 17 Aug 2020 03:24:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=MgrXubLA; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728037AbgHQKWi (ORCPT + 99 others); Mon, 17 Aug 2020 06:22:38 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:50066 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728033AbgHQKWg (ORCPT ); Mon, 17 Aug 2020 06:22:36 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1597659756; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=UHi/ozRmVDf+5fekjlpSZStl+2B7AhNxn2mgkOsi3Ew=; b=MgrXubLA6By/pps25IOLerYoNp6AUE2KVp4LkYoBbObLX9YRqq00WPDoCAHiES1l2x8hONog c6gAMHtU67NRZnfbmcczx72fwaOy4p7TrGT5EMRXLUc4KiIn54Wt5bjCQdDRfdBXIjLfxNSQ lkgnnXz8tTNDIzXoEUD5dvu+M7c= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-east-1.postgun.com with SMTP id 5f3a5a5ecbcd42bdeee529d4 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 17 Aug 2020 10:22:22 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 66AFAC433C6; Mon, 17 Aug 2020 10:22:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.5 required=2.0 tests=ALL_TRUSTED,MISSING_DATE, MISSING_MID,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id B5A54C433C6; Mon, 17 Aug 2020 10:22:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org B5A54C433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] ath6kl: prevent potential array overflow in ath6kl_add_new_sta() From: Kalle Valo In-Reply-To: <20200813141315.GB457408@mwanda> References: <20200813141315.GB457408@mwanda> To: Dan Carpenter Cc: Jakub Kicinski , Jouni Malinen , linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20200817102221.66AFAC433C6@smtp.codeaurora.org> Date: Mon, 17 Aug 2020 10:22:21 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Dan Carpenter wrote: > The value for "aid" comes from skb->data so Smatch marks it as > untrusted. If it's invalid then it can result in an out of bounds array > access in ath6kl_add_new_sta(). > > Fixes: 572e27c00c9d ("ath6kl: Fix AP mode connect event parsing and TIM updates") > Signed-off-by: Dan Carpenter > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 54f9ab7b8709 ath6kl: prevent potential array overflow in ath6kl_add_new_sta() -- https://patchwork.kernel.org/patch/11712551/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches