Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1597680075-18723-1-git-send-email-loic.poulain@linaro.org> <87pn7ojx8g.fsf@codeaurora.org>
In-Reply-To: <87pn7ojx8g.fsf@codeaurora.org>
From:   Loic Poulain <loic.poulain@linaro.org>
Date:   Tue, 18 Aug 2020 15:34:16 +0200
Message-ID: <CAMZdPi9sQ2BM4G2cSKNfE06fOtvOtgb+ELqAkxUJdtLbuoeYzQ@mail.gmail.com>
Subject: Re: [PATCH] wcn36xx: Fix software-driven scan
To:     Kalle Valo <kvalo@codeaurora.org>
Cc:     "Bryan O'Donoghue" <bryan.odonoghue@linaro.org>,
        wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Tue, 18 Aug 2020 at 08:15, Kalle Valo <kvalo@codeaurora.org> wrote:
>
> Loic Poulain <loic.poulain@linaro.org> writes:
>
> > For software-driven scan, rely on mac80211 software scan instead
> > of internal driver implementation. The internal implementation
> > cause connection trouble since it keep the antenna busy during
> > the entire scan duration, moreover it's only a passive scanning
> > (no probe request). Therefore, let mac80211 manages sw scan.
> >
> > Note: we fallback to software scan if firmware does not report
> > scan offload support or if we need to scan the 5Ghz band (currently
> > not supported by the offload scan...).
> >
> > Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
> > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>
> What changed since v2? Please always include a changelog so that I don't
> need to guess what you have changed in the patch. No need to resend, a
> reply is enough.

Yes sorry, this patch has been rebased on ath master and squashed with
Bryan's fix:
     wcn36xx: Set sw-scan chan to 0 when not associated
No additional changes have been made on top of the initial patches.

Regards,
Loic