Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 93F7AC433C6
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] brcmfmac: reserve tx credit only when txctl is ready to
 send
From:   Kalle Valo <kvalo@codeaurora.org>
In-Reply-To: <20200813070017.89023-1-wright.feng@cypress.com>
References: <20200813070017.89023-1-wright.feng@cypress.com>
To:     Wright Feng <wright.feng@cypress.com>
Cc:     linux-wireless@vger.kernel.org, wright.feng@cypress.com,
        brcm80211-dev-list@broadcom.com, brcm80211-dev-list@cypress.com,
        Arend van Spriel <arend.vanspriel@broadcom.com>,
        Franky Lin <franky.lin@broadcom.com>,
        Hante Meuleman <hante.meuleman@broadcom.com>,
        chi-hsien.lin@cypress.com, Dmitry Osipenko <digetx@gmail.com>
User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2
Message-Id: <20200818143322.07C0AC433CB@smtp.codeaurora.org>
Date:   Tue, 18 Aug 2020 14:33:22 +0000 (UTC)
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Wright Feng <wright.feng@cypress.com> wrote:

> The 4329 throughput drops from 40.2 Mbits/sec to 190 Kbits/sec in 2G
> 11n mode because the commit b41c232d33666 ("brcmfmac: reserve 2 credits
> for host tx control path"). To fix the issue, host driver only reserves
> tx control credit when there is a txctl frame is pending to send. And
> we also check available credit by using "not equal to 0" instead of
> "greater than 0" because tx_max and tx_seq are circled positive numbers.
> 
> Reported-by: Dmitry Osipenko <digetx@gmail.com>
> Fixes: b41c232d33666 ("brcmfmac: reserve 2 credits for host tx control path")
> Signed-off-by: Wright Feng <wright.feng@cypress.com>
> Tested-by: Dmitry Osipenko <digetx@gmail.com>

Patch applied to wireless-drivers.git, thanks.

9a2a0862d973 brcmfmac: reserve tx credit only when txctl is ready to send

-- 
https://patchwork.kernel.org/patch/11711809/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches