Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <4abebda6ee90ce59b9dc5121b07d1954841351c7.camel@sipsolutions.net>
Subject: Re: [PATCH] mac80211: send only vlan group traffics in 80211 xmit
 path
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Seevalamuthu Mariappan <seevalam@codeaurora.org>
Cc:     linux-wireless@vger.kernel.org
Date:   Wed, 19 Aug 2020 08:54:55 +0200
In-Reply-To: <1597819527-31887-1-git-send-email-seevalam@codeaurora.org>
References: <1597819527-31887-1-git-send-email-seevalam@codeaurora.org>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Wed, 2020-08-19 at 12:15 +0530, Seevalamuthu Mariappan wrote:
> AP-VLAN multicast/broadcast packets are expected to be encrypted
> in software. 

Err. Expected by whom?

> Those packets should follow 802.11 xmit path.

You should explain why ...

> -void __ieee80211_subif_start_xmit(struct sk_buff *skb,
> -				  struct net_device *dev,
> -				  u32 info_flags,
> -				  u32 ctrl_flags,
> -				  u64 *cookie)

There's no way I can review this if you move the whole function while
making a small change to it ...

johannes