Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Wed, 19 Aug 2020 13:23:03 +0530
From:   Seevalamuthu Mariappan <seevalam@codeaurora.org>
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: send only vlan group traffics in 80211 xmit
 path
In-Reply-To: <4abebda6ee90ce59b9dc5121b07d1954841351c7.camel@sipsolutions.net>
References: <1597819527-31887-1-git-send-email-seevalam@codeaurora.org>
 <4abebda6ee90ce59b9dc5121b07d1954841351c7.camel@sipsolutions.net>
Message-ID: <94f16e76ca54dc175a756a51a4907a1c@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Hi Johannes,

On 2020-08-19 12:24, Johannes Berg wrote:
> On Wed, 2020-08-19 at 12:15 +0530, Seevalamuthu Mariappan wrote:
>> AP-VLAN multicast/broadcast packets are expected to be encrypted
>> in software.
> 
> Err. Expected by whom?

Not an expectation exactly. As of now, AP-VLAN multicast/broadcast 
packets are encrypted in mac80211 itself. So these packets needs to go 
through 80211_xmit path. This change is just to redirect the other 
packets (unicast) to 802.3 xmit path if hw encap is enabled on AP 
interface.
> 
>> Those packets should follow 802.11 xmit path.
> 
> You should explain why ...
> 
>> -void __ieee80211_subif_start_xmit(struct sk_buff *skb,
>> -				  struct net_device *dev,
>> -				  u32 info_flags,
>> -				  u32 ctrl_flags,
>> -				  u64 *cookie)
> 
> There's no way I can review this if you move the whole function while
> making a small change to it ...

Will split into two patches, one having function movement and another 
patch having the actual change.
> 
> johannes


Thanks,
Seevalamuthu M