Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 90FADC433C6
From:   Kalle Valo <kvalo@codeaurora.org>
To:     John Crispin <john@phrozen.org>
Cc:     Miles Hu <milehu@codeaurora.org>, linux-wireless@vger.kernel.org,
        ath11k@lists.infradead.org
Subject: Re: [PATCH V6 2/2] ath11k: add more HE fields into radiotap header
References: <20200803145444.473810-1-john@phrozen.org>
        <20200803145444.473810-2-john@phrozen.org>
Date:   Wed, 19 Aug 2020 19:14:58 +0300
In-Reply-To: <20200803145444.473810-2-john@phrozen.org> (John Crispin's
        message of "Mon, 3 Aug 2020 16:54:44 +0200")
Message-ID: <87lfiaipdp.fsf@codeaurora.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

John Crispin <john@phrozen.org> writes:

> From: Miles Hu <milehu@codeaurora.org>
>
> This patch adds code to parse HE fields inside ppdu TLVs. Then it adds the
> populates the additional info into the ratiotap header. Also fix missing
> QoS tag in native wifi mode. Finally rssi and tsf are also added.
>
> Signed-off-by: Miles Hu <milehu@codeaurora.org>
> Signed-off-by: John Crispin <john@phrozen.org>

[...]

> @@ -4522,11 +4522,14 @@ ath11k_dp_rx_mon_merg_msdus(struct ath11k *ar,
>  			    struct ieee80211_rx_status *rxs)
>  {
>  	struct sk_buff *msdu, *mpdu_buf, *prev_buf;
> -	u32 decap_format, wifi_hdr_len;
> +	u32 decap_format;
>  	struct hal_rx_desc *rx_desc;
>  	char *hdr_desc;
>  	u8 *dest;
>  	struct ieee80211_hdr_3addr *wh;
> +	static u32 pkt_type;
> +
> +	pkt_type++;

We cannot use static non-const variables in ath11k, that would be racy.
As this seems to be an unused variable I have just removed it in the
pending branch.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches