Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 20 Aug 2020 10:49:26 +0300
From:   Sergey Matyukevich <geomatsi@gmail.com>
To:     Tamizh Chelvam <tamizhr@codeaurora.org>
Cc:     johannes@sipsolutions.net, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] iw: add TID specific Tx bitrate configuration
Message-ID: <20200820074926.GA2255@curiosity>
References: <1597903916-8674-1-git-send-email-tamizhr@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1597903916-8674-1-git-send-email-tamizhr@codeaurora.org>
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Hello Tamizh,

> Add TID specific Tx bitrate configuration by using
> handle_bitrates already APIs.
> 
> Examples:
> 	$ iw dev wlan0 peer xx:xx:xx:xx:xx:xx tids 0x2 bitrates auto
> 	$ iw dev wlan0 peer xx:xx:xx:xx:xx:xx tids 0x2 bitrates limit vht-mcs-5 4:9
> 
> Signed-off-by: Tamizh Chelvam <tamizhr@codeaurora.org>
> ---
>  bitrate.c   | 27 ++++++++++++++++++++-------
>  interface.c | 34 +++++++++++++++++++++++++++++++++-
>  iw.h        |  3 +++
>  3 files changed, 56 insertions(+), 8 deletions(-)

...

>  COMMAND(set, tidconf, "[peer <MAC address>] tids <mask> [override] [sretry <num>] [lretry <num>] "
> -	"[ampdu [on|off]] [amsdu [on|off]] [noack [on|off]] [rtscts [on|off]]",
> +	"[ampdu [on|off]] [amsdu [on|off]] [noack [on|off]] [rtscts [on|off]]"
> +	"[bitrates <type [auto|fixed|limit]> [legacy-<2.4|5> <legacy rate in Mbps>*] [ht-mcs-<2.4|5> <MCS index>*]"
> +	" [vht-mcs-<2.4|5> <NSS:MCSx,MCSy... | NSS:MCSx-MCSy>*] [sgi-2.4|lgi-2.4] [sgi-5|lgi-5]]",
>  	NL80211_CMD_SET_TID_CONFIG, 0, CIB_NETDEV, handle_tid_config,
>  	"Setup per-node TID specific configuration for TIDs selected by bitmask.\n"
>  	"If MAC address is not specified, then supplied TID configuration\n"
> @@ -955,4 +985,6 @@ COMMAND(set, tidconf, "[peer <MAC address>] tids <mask> [override] [sretry <num>
>  	"  $ iw dev wlan0 tids 0x5 ampdu off amsdu off rtscts on\n"
>  	"  $ iw dev wlan0 tids 0x3 override ampdu on noack on rtscts on\n"
>  	"  $ iw dev wlan0 peer xx:xx:xx:xx:xx:xx tids 0x1 ampdu off tids 0x3 amsdu off rtscts on\n"
> +	"  $ iw dev wlan0 peer xx:xx:xx:xx:xx:xx tids 0x2 bitrates auto\n"
> +	"  $ iw dev wlan0 peer xx:xx:xx:xx:xx:xx tids 0x2 bitrates limit vht-mcs-5 4:9\n"

It just occured to me that I wrote incorrect help message in the patch
adding tidconf command. IIRC the correct usage should be: 

$ iw dev wlan0 set tidconf peer 1:2:3:4:5:6 tids 0x3 ampdu off tids 0x2 sretry 10 lretry 100
$ iw dev wlan0 set tidconf tids 0xff ampdu off amsdu off sretry 10 lretry 100 noack off

Could you please update new help entries and fix the existing ones ?


Regards,
Sergey