Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp373377pxa; Fri, 21 Aug 2020 09:23:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyr4e6K50sP1BEiy04epGvaNTxyvFY6rhF02jMFLRiXMVNjR1Ydl6op9mbqxaS9KI92PKRB X-Received: by 2002:a17:906:f24c:: with SMTP id gy12mr3450610ejb.275.1598027020834; Fri, 21 Aug 2020 09:23:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598027020; cv=none; d=google.com; s=arc-20160816; b=LLwjgU1v62CcdeFPv+mmK5nTg3Ze0zD0oZTGqL9ONqfIRgNqFbMvygw1pyrAJKubTe JQg/KS2wPTwvYIY9+LvZxM+XkGstgWHNC1um5B+Xd8vnM6GFoDvVV8PyxsPjn0ObokCB HFLJdKbDyEbH0ZIWXhO5bR0GZE+VemxBWPKrqCrNUVipsD8ga4GyNaiHSIZIdAGULqdY uUASTJ8XA2MHVMCcQx4gJoEOlX5b0Abkz0CRaKbgRdlk2jUWop75KlelIahZm3OULpd4 qYGydt+d8ojLGQMcWjS9InYgmOt96AqDFV0l1eBogVd1WmNBBlnf60iWickgUZp6goV8 5SaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:dkim-signature; bh=HagV7JDRm/kfP9ix7ReYcl1/XVHJCqBmI1V8eEPtgGA=; b=SeWEhXesHo0Xa9KOhfHuxGXC25e2qwQ5HqyzymhTkJZ5Sc7kqjLX0DaqGYJXHWKvoK gE8tPO9k/UPyMPfSnatuCwY05NGT2ASopGObNedn3QuyP83/yOD+EOcOT3aCd1GcOLIJ 5KUR30c6NlDsregQXZW0tsNqH7d7l7JnOTbA6d3rUvmIz7QhDhKNZGkI3vYvPf23ItkB e3JcCJk8HPo4EvRqJ2tjGOchuwealj5ubhA8OAgc3livfO23TFFQP2imyvDM7WiD3spv kC/rZyIdaxIdnu7bsfO0NtpGkgJPWo4mLIbzHmnLcD555Jqd7x4gxG/GFGi5Y167C8JX xg6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=GjYRfYbC; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r10si1464276edy.93.2020.08.21.09.23.15; Fri, 21 Aug 2020 09:23:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=GjYRfYbC; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728514AbgHUQWk (ORCPT + 99 others); Fri, 21 Aug 2020 12:22:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728415AbgHUQWh (ORCPT ); Fri, 21 Aug 2020 12:22:37 -0400 Received: from nbd.name (nbd.name [IPv6:2a01:4f8:221:3d45::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BFEACC061573 for ; Fri, 21 Aug 2020 09:22:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=HagV7JDRm/kfP9ix7ReYcl1/XVHJCqBmI1V8eEPtgGA=; b=GjYRfYbCrvdjJBulFZBCHSWC9i tRV8bL6LBSvQWTm3R1LIhkj5kuv1o7EVx9+Fa36fYVaI2ispvPTmiTqY0aWlxB7SGxw/a6pPGEv0r jsJBvGiCdPRNWUHfOW4hYaXznL9SprrtI36tb/1vsNFTM6yZQv9AxiyqSY/ra/ffeAfU=; Received: from p5b206497.dip0.t-ipconnect.de ([91.32.100.151] helo=nf.local) by ds12 with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1k99oE-0002ye-Jl; Fri, 21 Aug 2020 18:22:30 +0200 Subject: Re: [PATCH 5.9 3/3] mac80211: improve AQL aggregation estimation for low data rates To: =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= , Sebastian Gottschall , linux-wireless@vger.kernel.org Cc: johannes@sipsolutions.net References: <20200813155212.97884-1-nbd@nbd.name> <20200813155212.97884-3-nbd@nbd.name> <87tuww2ggm.fsf@toke.dk> <61d66ec8-117e-7c75-2b4a-1de7715f0bce@dd-wrt.com> <87r1s02eve.fsf@toke.dk> From: Felix Fietkau Autocrypt: addr=nbd@nbd.name; prefer-encrypt=mutual; keydata= xsDiBEah5CcRBADIY7pu4LIv3jBlyQ/2u87iIZGe6f0f8pyB4UjzfJNXhJb8JylYYRzIOSxh ExKsdLCnJqsG1PY1mqTtoG8sONpwsHr2oJ4itjcGHfn5NJSUGTbtbbxLro13tHkGFCoCr4Z5 Pv+XRgiANSpYlIigiMbOkide6wbggQK32tC20QxUIwCg4k6dtV/4kwEeiOUfErq00TVqIiEE AKcUi4taOuh/PQWx/Ujjl/P1LfJXqLKRPa8PwD4j2yjoc9l+7LptSxJThL9KSu6gtXQjcoR2 vCK0OeYJhgO4kYMI78h1TSaxmtImEAnjFPYJYVsxrhay92jisYc7z5R/76AaELfF6RCjjGeP wdalulG+erWju710Bif7E1yjYVWeA/9Wd1lsOmx6uwwYgNqoFtcAunDaMKi9xVQW18FsUusM TdRvTZLBpoUAy+MajAL+R73TwLq3LnKpIcCwftyQXK5pEDKq57OhxJVv1Q8XkA9Dn1SBOjNB l25vJDFAT9ntp9THeDD2fv15yk4EKpWhu4H00/YX8KkhFsrtUs69+vZQwc0cRmVsaXggRmll dGthdSA8bmJkQG5iZC5uYW1lPsJgBBMRAgAgBQJGoeQnAhsjBgsJCAcDAgQVAggDBBYCAwEC HgECF4AACgkQ130UHQKnbvXsvgCgjsAIIOsY7xZ8VcSm7NABpi91yTMAniMMmH7FRenEAYMa VrwYTIThkTlQzsFNBEah5FQQCACMIep/hTzgPZ9HbCTKm9xN4bZX0JjrqjFem1Nxf3MBM5vN CYGBn8F4sGIzPmLhl4xFeq3k5irVg/YvxSDbQN6NJv8o+tP6zsMeWX2JjtV0P4aDIN1pK2/w VxcicArw0VYdv2ZCarccFBgH2a6GjswqlCqVM3gNIMI8ikzenKcso8YErGGiKYeMEZLwHaxE Y7mTPuOTrWL8uWWRL5mVjhZEVvDez6em/OYvzBwbkhImrryF29e3Po2cfY2n7EKjjr3/141K DHBBdgXlPNfDwROnA5ugjjEBjwkwBQqPpDA7AYPvpHh5vLbZnVGu5CwG7NAsrb2isRmjYoqk wu++3117AAMFB/9S0Sj7qFFQcD4laADVsabTpNNpaV4wAgVTRHKV/kC9luItzwDnUcsZUPdQ f3MueRJ3jIHU0UmRBG3uQftqbZJj3ikhnfvyLmkCNe+/hXhPu9sGvXyi2D4vszICvc1KL4RD aLSrOsROx22eZ26KqcW4ny7+va2FnvjsZgI8h4sDmaLzKczVRIiLITiMpLFEU/VoSv0m1F4B FtRgoiyjFzigWG0MsTdAN6FJzGh4mWWGIlE7o5JraNhnTd+yTUIPtw3ym6l8P+gbvfoZida0 TspgwBWLnXQvP5EDvlZnNaKa/3oBes6z0QdaSOwZCRA3QSLHBwtgUsrT6RxRSweLrcabwkkE GBECAAkFAkah5FQCGwwACgkQ130UHQKnbvW2GgCfTKx80VvCR/PvsUlrvdOLsIgeRGAAn1ee RjMaxwtSdaCKMw3j33ZbsWS4 Message-ID: <623a2b24-31c8-83be-ae24-1461ecbfc224@nbd.name> Date: Fri, 21 Aug 2020 18:22:30 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <87r1s02eve.fsf@toke.dk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2020-08-21 17:33, Toke Høiland-Jørgensen wrote: > Sebastian Gottschall writes: > >> i mean airtime fairness policy was not configured > > Ah, right, that makes a lot more sense :) > > Still not sure why this would affect throughput, though; maybe the > change in calculation makes AQL overestimate the airtime and throttle > too much? Or does the saving of last_rate_info on tx_status_ext() work > badly for ath10k? The issue turned out to be missing return code checks on converting the tx rate to struct ieee80211_rx_status. I'll send v2 of this series with fixes. - Felix