Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@redhat.com>
To:     Felix Fietkau <nbd@nbd.name>,
        Sebastian Gottschall <s.gottschall@dd-wrt.com>,
        linux-wireless@vger.kernel.org
Cc:     johannes@sipsolutions.net
Subject: Re: [PATCH 5.9 3/3] mac80211: improve AQL aggregation estimation
 for low data rates
In-Reply-To: <623a2b24-31c8-83be-ae24-1461ecbfc224@nbd.name>
References: <20200813155212.97884-1-nbd@nbd.name>
 <20200813155212.97884-3-nbd@nbd.name>
 <c3c5197f-17f7-4f6b-712f-d7c68f39ae38@dd-wrt.com> <87tuww2ggm.fsf@toke.dk>
 <61d66ec8-117e-7c75-2b4a-1de7715f0bce@dd-wrt.com> <87r1s02eve.fsf@toke.dk>
 <623a2b24-31c8-83be-ae24-1461ecbfc224@nbd.name>
Date:   Fri, 21 Aug 2020 18:37:50 +0200
Message-ID: <87lfi82bvl.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Felix Fietkau <nbd@nbd.name> writes:

> On 2020-08-21 17:33, Toke H=C3=B8iland-J=C3=B8rgensen wrote:
>> Sebastian Gottschall <s.gottschall@dd-wrt.com> writes:
>>=20
>>> i mean airtime fairness policy was not configured
>>=20
>> Ah, right, that makes a lot more sense :)
>>=20
>> Still not sure why this would affect throughput, though; maybe the
>> change in calculation makes AQL overestimate the airtime and throttle
>> too much? Or does the saving of last_rate_info on tx_status_ext() work
>> badly for ath10k?
> The issue turned out to be missing return code checks on converting the
> tx rate to struct ieee80211_rx_status.
> I'll send v2 of this series with fixes.

Ah, great! :)

-Toke