Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <f57db5715fe2177ae4901ba981fdc3a580b94b54.camel@sipsolutions.net>
Subject: Re: [PATCH] cfg80211: Add feature flag to indicate RSNXE IE support
 in FT
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Veerendranath Jakkam <vjakkam@codeaurora.org>
Cc:     linux-wireless@vger.kernel.org
Date:   Thu, 27 Aug 2020 11:33:12 +0200
In-Reply-To: <1596511970-8415-1-git-send-email-vjakkam@codeaurora.org>
References: <1596511970-8415-1-git-send-email-vjakkam@codeaurora.org>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Tue, 2020-08-04 at 09:02 +0530, Veerendranath Jakkam wrote:
> Add a new feature flag that drivers in which FT handshake is offloaded,

"that drivers (in which ...)" what? Can set? Are expected to use?

> to advertise support for interoperability with legacy clients which
> doesn't

don't? or what does "doesn't" refer to?

>  support using RSNXE IE for MIC calculation in FT handshake. The
> userspace can choose to enable/disable FT protocols that require RSNXE IE
> to be used based on this flag advertised by drivers.

I can't say I really understand this.

> Signed-off-by: Veerendranath Jakkam <vjakkam@codeaurora.org>
> 
> diff --git a/include/uapi/linux/nl80211.h b/include/uapi/linux/nl80211.h
> index 631f3a99..83e8079 100644
> --- a/include/uapi/linux/nl80211.h
> +++ b/include/uapi/linux/nl80211.h
> @@ -5820,6 +5820,9 @@ enum nl80211_feature_flags {
>   * @NL80211_EXT_FEATURE_4WAY_HANDSHAKE_AP_PSK: Device wants to do 4-way
>   *	handshake with PSK in AP mode (PSK is passed as part of the start AP
>   *	command).
> + * @NL80211_EXT_FEATURE_FT_RSNXE: Driver supports RSNXE element in FT handshake
> + *	and interoperable with legacy clients that doesn't support using RSNXE
> + *	IE for MIC computation in FT handshake.

Nor this. Please rewrite the commit message and comment to be more
explanatory (and grammatically correct).

johannes