Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp304379pxa; Thu, 27 Aug 2020 02:50:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzDtLNGh3DbvuR8C7owrsGj+30QZ3v9ctykTKoSoqOCxZcbLl1ToyBH6emMXHAHym3lSO7W X-Received: by 2002:a50:e846:: with SMTP id k6mr18550194edn.27.1598521823580; Thu, 27 Aug 2020 02:50:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598521823; cv=none; d=google.com; s=arc-20160816; b=DcAC1dnkPWsgsy0doOlqWn5YscQ5x7xzu9swezHgqb9O2TWO+uqcEJt6ut1eO9J5qd naP84X7ciBgYP+Wc7Kx8kuye3jeT/5oSB1sZU9KmqGHoIDCfL81DlEIPqfSAZo85ZZtr j7lOxAIgFq1EbAW2hKOONXMs0q7x9VD7Goz7zTtZfUU6C1ju/Ih5SVit6uCrTV/i8DQc FXKcN8XFUwDa9IGqfPfcs7Ygc2yEVO+ZxrB7++yybIH1b71CO5r2Mu67jhNc9U9rQRKn xbIla2yFnMRz5XHlyIhLDGv9FWSoL5uEPBOBGcs0w4pV1zWYfuUVQkulHPHVGGL2zs38 aqXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=sK7OIa4hAS4DFuYP9w0I0P4oBG+aNV3oNB41g7NxRLc=; b=huoqo0PXw90OhyK6ihTKdTLNJkvlzlHQPaNVxUD0nBFBlNrmf5RxsJgQWZCJvXu4Rv SvoX8BxmHglqx+dphhQYfIDVHbmB1zv/15PInHMWFOFOQ+Nx9JfgsZOBvDNDVfFbRYF3 WW00sLeSt2lwU035EhS3K9PRN2C00cABFJb/emSNJMFjh29l41JRXcTiH2cNV4W95YTD 1noDId6DMraulR61drdcDjM6vnQgbXGmVyfwiAs7/POn53tjaFd4wjUVq3gf/wUBAmbN xxXlzfEJFqpgoLIbTB2eFAGMnBa8G/H0Jm2J8TsaNNAV/HDnOCCUfWvUnpFxz8Pbyja9 guag== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h9si1010550ejl.393.2020.08.27.02.49.58; Thu, 27 Aug 2020 02:50:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728072AbgH0JsL (ORCPT + 99 others); Thu, 27 Aug 2020 05:48:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726826AbgH0JsI (ORCPT ); Thu, 27 Aug 2020 05:48:08 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5BFBC061264 for ; Thu, 27 Aug 2020 02:48:08 -0700 (PDT) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94) (envelope-from ) id 1kBEVq-00BX86-Vh; Thu, 27 Aug 2020 11:48:07 +0200 Message-ID: <5ca724421a6a9d8be3402e10dbd62a19b910b03a.camel@sipsolutions.net> Subject: Re: [PATCH v5 2/2] mac80211: Add FILS discovery support From: Johannes Berg To: Aloka Dixit Cc: linux-wireless@vger.kernel.org Date: Thu, 27 Aug 2020 11:48:06 +0200 In-Reply-To: <20200805011838.28166-3-alokad@codeaurora.org> References: <20200805011838.28166-1-alokad@codeaurora.org> <20200805011838.28166-3-alokad@codeaurora.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org > + * @IEEE80211_HW_SUPPORTS_FILS_DISCOVERY: Hardware/driver supports FILS > + * discovery frame transmission nit: extra space before the @ but in any case you really ought to just remove this, the driver can set up whatever method you decide to use in cfg80211 (e.g. extended feature flag) - no need for mac80211 to have extra code just to pass it through. The flags here are intended for things that only mac80211 cares about. johannes