Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp311811pxa; Thu, 27 Aug 2020 03:04:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy1YKO3AuIFBLmqyGMj5OhZDkB5VgRmcFhuOmRiwWDTgImO2qmSFSsu38jzXMdaFiRTyQbJ X-Received: by 2002:a17:906:6ad8:: with SMTP id q24mr19976180ejs.192.1598522653270; Thu, 27 Aug 2020 03:04:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598522653; cv=none; d=google.com; s=arc-20160816; b=ZSC1tAbmYEeS9F0Sj01IQzz4y1n2INKq31+25zVDTO29UpHC0sg+xkJzw3Gjv7Drgh gDj9XcONKTyiQ/ZGMMmqUZz5Q5PevcVlAjL+KaB7EAvMLfrfqoTO4rj5XUgwliEvLau3 llwvZejNQtzVBxrslD0Q3U+54vunIKsSdUVlgabMSOE3BVX5FoiEwYQFVe40mPr9PiRm OVWC94Ru7h3Qco+shj4s5gbSQ5blhVD0D1O14nfPJ6xdcfmD9ZuR1SLWLMqC0BHk4o1+ RtOKmoukU/AiIn7MapXiFKEpdTSY1TNnh4jquaxsoLBTeDrNCcsGqh+EtQWvG7e15e8x z7jQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature; bh=rv0P6J7OYmXCE2KVpOiobH3kXlv30j41Xb0jzb6avXo=; b=GN0pVBjmRPD6CJklFRYn0eXvEEIByQ+5fXBfjHOoTmMPP2qYEfsdqY1cY+MG/uEGvV SMhZig3H7BJZI3+z1ZFKhhmVPR8QMSA9O5hrPlbDhRdbgQYgeLoLLhoCuExGNehoo921 nQdePJ2vy3HRS8STEUfPNV1/CJr/lDXrM+amKxrn7rp+CRLg6EnDPxklOwUmgU4WBcAt Yi/oWuAmEI/NUC6K1mFYYFKfj2VT2rVCCwGRhODULXwGCf9OegMUWdbO+Nr2dtQGA76Y MRQHW9RenQQs8uo5ObJQGOCQPC1vowIZvOSEWMHgrd4bGu2l9TwnqoSskcNsjcyXIuRD GKqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=YiEgoJHH; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 89si1162328edr.198.2020.08.27.03.03.49; Thu, 27 Aug 2020 03:04:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=YiEgoJHH; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728759AbgH0KDk (ORCPT + 99 others); Thu, 27 Aug 2020 06:03:40 -0400 Received: from mail29.static.mailgun.info ([104.130.122.29]:27346 "EHLO mail29.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728748AbgH0KDb (ORCPT ); Thu, 27 Aug 2020 06:03:31 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1598522611; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=rv0P6J7OYmXCE2KVpOiobH3kXlv30j41Xb0jzb6avXo=; b=YiEgoJHHeJYupRZhthwKidiEkgn6Nk7wH4f09jnG3dFyUkXMnc+C8VwpzugIx7xzaIPXpMHF +Gq7XQY3qUi81SwUTiA3boprVzirYROmy9XcbRD3B5cJyXJ0b2pCu8Xc1ye/xKAjh6VkfqKx Tba0CEEA3nRLyyciUVbUSTpo3f0= X-Mailgun-Sending-Ip: 104.130.122.29 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n03.prod.us-west-2.postgun.com with SMTP id 5f4784d72fd6d21f0a9cc979 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 27 Aug 2020 10:03:03 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 3C929C433A1; Thu, 27 Aug 2020 10:03:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.5 required=2.0 tests=ALL_TRUSTED,MISSING_DATE, MISSING_MID,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 3972EC433C6; Thu, 27 Aug 2020 10:03:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 3972EC433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] [v2] wilc1000: Fix memleak in wilc_bus_probe From: Kalle Valo In-Reply-To: <20200820055256.24333-1-dinghao.liu@zju.edu.cn> References: <20200820055256.24333-1-dinghao.liu@zju.edu.cn> To: Dinghao Liu Cc: dinghao.liu@zju.edu.cn, kjlu@umn.edu, Ajay Singh , Claudiu Beznea , "David S. Miller" , Jakub Kicinski , Greg Kroah-Hartman , Adham Abozaeid , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20200827100303.3C929C433A1@smtp.codeaurora.org> Date: Thu, 27 Aug 2020 10:03:03 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Dinghao Liu wrote: > When devm_clk_get() returns -EPROBE_DEFER, spi_priv > should be freed just like when wilc_cfg80211_init() > fails. > > Fixes: 854d66df74aed ("staging: wilc1000: look for rtc_clk clock in spi mode") > Signed-off-by: Dinghao Liu > Acked-by: Ajay Singh Patch applied to wireless-drivers-next.git, thanks. 9a19a939abfa wilc1000: Fix memleak in wilc_bus_probe -- https://patchwork.kernel.org/patch/11725515/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches