Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp313349pxa; Thu, 27 Aug 2020 03:06:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwoBMTuIpd3Vu0UXzqoNkdBObu48EMwHR0iPdoxsdtuDQ6f36h6/wnSU8FyAV6nv1+B5ZDt X-Received: by 2002:a17:906:2a49:: with SMTP id k9mr20638955eje.117.1598522814965; Thu, 27 Aug 2020 03:06:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598522814; cv=none; d=google.com; s=arc-20160816; b=Aqut9vFPxujG8CrEn/32S0gSOJqs5tIxTBqtQ18Y0MUsfGaEdt2WUnHDFR53CKD0LJ ucowa2LmLkBo8FULzjlxTa8oRRdvITOqvcbZJoJBM1LaA8zvUPBChOSU4tXhd1nvAiwR EyMyJpAU1kU5JdtjdZSdya5qH2Uru+pebmmEapFrwYgAowv5nv5FkGw1xH3qDmfgkUXu +3TZDu6SsDfq5UkbcU9AtIZQUz5GBqRmebZDRCsHQB+zRuhaxp4LlwUHu0bd0sZfC/LO cANH3mpAachm/K/DVpmdwDDo1LZlI5kqLp9bYAC7HjAPwQqWwch4RdC1rhQfx4FRpcOq eJwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature; bh=kKxRrosUk4+JXqyUQN4HVkd0wJGJEwRdPu3QcR8Pk+o=; b=awIHwD0eIjKqvXUYacoNIADZnce671G2Q+LbAGfSpxH2B3A+IEtld8SB5u1sIcgCJ7 PiDFI08wotDzvBy7pbfyiBIQZ/6vmZcqaCzgC3lkgXyPy8xdYQLRyVLAtgJ02wbLuW5Z 0EeEhUfK/HIvoIvb8S0td8g3FKj0WbeYvCJa294wGUz/qE/m1Uy2R/U2qvSp1sc5oXWR 8tDVQfN+H3a03OBh4HT9l2Tc6PKp0MIEGiZqYhH0g5+MMlCIcvc+7q2gBzWi0srvdSRj dUKHbuaoQbGH8KFZkHLQ0jjC2zh78SY3lKuQa8quFBQZrmCaahw5dBOnwfZHDHa2/3Lr MgIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=ZZt9SisB; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u1si1219590edd.388.2020.08.27.03.06.30; Thu, 27 Aug 2020 03:06:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=ZZt9SisB; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728372AbgH0KEr (ORCPT + 99 others); Thu, 27 Aug 2020 06:04:47 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:24994 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727802AbgH0KEq (ORCPT ); Thu, 27 Aug 2020 06:04:46 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1598522686; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=kKxRrosUk4+JXqyUQN4HVkd0wJGJEwRdPu3QcR8Pk+o=; b=ZZt9SisBLrfPebnjjacNDcgVUKq6Mr+kc+SoLwvs8QgRiWg4kF/8CSuKoacPkrHRe4uwOL5q /ZyrP8eZXv0jDpRi6sTTFEwzKh8rBtraXo4GDLaek+dERLXeT37i+Pz4BVVCLpNK1Muh6W65 OmYfl1rMYn2VxEn3twCz0P/M+tw= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n03.prod.us-east-1.postgun.com with SMTP id 5f478530c9ede11f5e71780b (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 27 Aug 2020 10:04:32 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 41992C433CB; Thu, 27 Aug 2020 10:04:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.5 required=2.0 tests=ALL_TRUSTED,MISSING_DATE, MISSING_MID,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id CC66FC433C6; Thu, 27 Aug 2020 10:04:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org CC66FC433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] rtw88: don't treat NULL pointer as an array From: Kalle Valo In-Reply-To: <20200821211716.1631556-1-briannorris@chromium.org> References: <20200821211716.1631556-1-briannorris@chromium.org> To: Brian Norris Cc: , Yan-Hsuan Chuang , Brian Norris User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20200827100431.41992C433CB@smtp.codeaurora.org> Date: Thu, 27 Aug 2020 10:04:31 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Brian Norris wrote: > I'm not a standards expert, but this really looks to be undefined > behavior, when chip->dig_cck may be NULL. (And, we're trying to do a > NULL check a few lines down, because some chip variants will use NULL.) > > Fixes: fc637a860a82 ("rtw88: 8723d: Set IG register for CCK rate") > Signed-off-by: Brian Norris > Acked-by: Yan-Hsuan Chuang Patch applied to wireless-drivers-next.git, thanks. 22b726cbdd09 rtw88: don't treat NULL pointer as an array -- https://patchwork.kernel.org/patch/11730581/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches