Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp391291pxa; Thu, 27 Aug 2020 05:27:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyWOMeO2Z+sITablWrdcLG0QsBplxQjfU4wu929Yx94BcrZBazb2vNsI1eP3l21TJVq9Rz6 X-Received: by 2002:a05:6402:17d8:: with SMTP id s24mr18730991edy.61.1598531226564; Thu, 27 Aug 2020 05:27:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598531226; cv=none; d=google.com; s=arc-20160816; b=i0+bsI56yZGee4pdTYPtW0pnWR2FYaxqbQXioMIVGOvl5QMXocR0NDwxbbMLD0qLNH KzWBQ5Ka0nXW8+jb6jEATHwrKvo6K/yzRwqwBGKMbLb2nyqPE08ug+3915mWrm95Bqi5 XbdzjHUzoA0oEPIMpn/eW61ncYCPPU9Pi8gL0oL4pyGGcDB1abwPWUmlomoHP4UyDurA /SUfRHBNn7tPp/BFar6IS9xnDVPEKwO99d2EncAyED4cQqbUO3Qn37vTxqVQyWiMWr/m HDEe8BAscwUFzcvxG+KpLvQ0KVg9Hy8KRm09cMKbnk5DgfMSrIFdWD6YZcFs4t+nCh9U Pg1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=CrXfwnoW87fgUYZQueJMcm7VBItLx60eeYEVViCOVdY=; b=jilc54ZcS+9bv/PL1h7gx0OC+V1tR+emXC4+GYq5uCp1Wva2YpDjn7c3AXmSRhtw7g fGLV/d9pSfxphyZdEKhWW64whEBXvKFshNOmlJJWJtFsP96Si0OM8k9w0uuKCsn86G4L xmQ7g3BNprRAnwEK/QHmp9hx2eZCtx6g/D+AOlKySdpslZDWRqKATrMJc9f6/C8R5Jxi j7gpx8Wtyyf78zAgGR7g7OYNQcNqtGdHU04+3wwzqOOu2XNdW86HFc7sttpHcPpnlmcm 8ZVbHq6qljcuy08FAyUqBFG4bGBaMM7m910mc5mC2FiGOKHqDfO5bEfln8WIT+l0j12L p/Uw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i10si1417312edu.323.2020.08.27.05.26.40; Thu, 27 Aug 2020 05:27:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729033AbgH0MZl (ORCPT + 99 others); Thu, 27 Aug 2020 08:25:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728991AbgH0MYs (ORCPT ); Thu, 27 Aug 2020 08:24:48 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9F96C061235 for ; Thu, 27 Aug 2020 05:24:47 -0700 (PDT) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94) (envelope-from ) id 1kBGxS-00BaJ7-0F; Thu, 27 Aug 2020 14:24:46 +0200 Message-ID: Subject: Re: [PATCH V5 3/5] nl80211: add support for BSS coloring From: Johannes Berg To: John Crispin Cc: linux-wireless@vger.kernel.org, ath11k@lists.infradead.org Date: Thu, 27 Aug 2020 14:24:45 +0200 In-Reply-To: <20200826055650.1101224-3-john@phrozen.org> (sfid-20200826_075709_238174_DD905459) References: <20200826055650.1101224-1-john@phrozen.org> <20200826055650.1101224-3-john@phrozen.org> (sfid-20200826_075709_238174_DD905459) Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org > + if (info->attrs[NL80211_ATTR_CNTDWN_OFFS_PRESP]) { > + params.counter_offset_presp = > + nla_get_u16(info->attrs[NL80211_ATTR_CNTDWN_OFFS_PRESP]); You need to check the attribute size here, apparently only exactly a single counter is supported. I'm not really sure *why* though - wouldn't be that much more difficult to add support for an arbitrary number in mac80211? Either way this is missing a check. johannes