Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp416016pxa; Thu, 27 Aug 2020 06:06:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyheaoMXa085hMy3ftpZQLSVSbl1my8f22jkIjEb1b5WqMg2BgiLpl5/2GTmzYvwQKZhZh6 X-Received: by 2002:aa7:cb05:: with SMTP id s5mr4297337edt.212.1598533600312; Thu, 27 Aug 2020 06:06:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598533600; cv=none; d=google.com; s=arc-20160816; b=XA8Bg9sLhgtBPrRS3jTvIXFl0GkiKZjXix8qEXpk1htZFAPgM3nPCZq87ZEWXtWKV5 sdh9HOhmGc9njd8w6ahnT7G0LWk6pVBOsOCyyIEFHkfheyjNN6dQBCiZi9VGcSernIgv 0BhQMhy/wDwH8nUzvRW7yxx5vgJuFfOE5CUGI2lIYkdinKmUj4Oevz0KZNXbH3dXn3X4 bb/bMGr7ioboSWCmplhR+e1cQ48olN5WbtEuNm3F1+SCc5v1JDjwLOR6GA5/2apYG+Dl 5I8OCuunA9teISGgW8zk9UT/sfZXAUrHZsSbZviNsUlbny5PQNr18w9fAy0iPGh0sDZb hnhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=rSyQE+RanaGFFP1OxpAZpntgwHE++WF8qj+OG68jP2M=; b=LgZ6EhVW11pkTETLxcGJm8UfpUoPKtvEzzL8Zy2sN4VBkL85Ne6/4XqWEHjq1RlXG0 ZW8Zsy6JTm59uk/hiY9/Z5mlimzOsnMsBZqqq6in6VJFjqFJGKQPGzZ2ida3LX0bvRha zBdjztEKvUx8urhf9fOBjcAQZuTM9grK9IQl0c7uapNQ8RxRuRQSWukJDO/3REBMBAWK xhpfZ5G5f3Y93/X32Q5NzeYxthvgpRJO60rSniCXMhI/jq6GaVd5ryxuGX2TDR+SYvIW MsrX8Ed4rK7FaWJCUtmBYdMPfw01QdhpLzUXSQ/+vqAOu0zVnnHkYcZ6M9f2QEO82jCJ WFvw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l14si1317666ejz.216.2020.08.27.06.06.10; Thu, 27 Aug 2020 06:06:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726256AbgH0NFK (ORCPT + 99 others); Thu, 27 Aug 2020 09:05:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726307AbgH0NE6 (ORCPT ); Thu, 27 Aug 2020 09:04:58 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C778AC061233 for ; Thu, 27 Aug 2020 06:04:00 -0700 (PDT) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94) (envelope-from ) id 1kBHZP-00Bb7X-3b; Thu, 27 Aug 2020 15:03:59 +0200 Message-ID: Subject: Re: [PATCH V3 2/9] mac80211: add multiple bssid support to interface handling From: Johannes Berg To: John Crispin Cc: linux-wireless@vger.kernel.org, ath11k@lists.infradead.org Date: Thu, 27 Aug 2020 15:03:55 +0200 In-Reply-To: <20200812150050.2683396-3-john@phrozen.org> References: <20200812150050.2683396-1-john@phrozen.org> <20200812150050.2683396-3-john@phrozen.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org > + struct { > + struct ieee80211_vif *parent; > + struct list_head list; Is there a lot of value in having a separate list, vs. iterating all interfaces and checking the parent pointer? And exposing the list to the driver seems like a bad idea anyway, they can't really get locking right. (to be continued, mail client is acting up) johannes