Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp494729pxa; Thu, 27 Aug 2020 07:55:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyI9y06AkS7ibZu5jQjlMZX5nQEvrn4px9HPeOr9WXJcTIVVv9ADXwfVr7h8rDjQY0LVo7N X-Received: by 2002:a17:906:a182:: with SMTP id s2mr20818109ejy.526.1598540107738; Thu, 27 Aug 2020 07:55:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598540107; cv=none; d=google.com; s=arc-20160816; b=VfGgxn8QN0h7FUQbv8lEKzw/fuWkoTjL4aRYWAehPK22Yl658Cmh+gxmKL5bkcbcMy G1Yk2dH8jlH6wIP9xnO16cJaE7+vefF1avKm4UEkwPphVJk+ZZqsReaKskxbAml4OeZZ ad31p6iDyrv2VeLO7fEUfK2mOPjBWM0wf9MfpjK9MZ75vAiHWjv6HLBx922Y7XoZO0Pw D3J44Ciw9DDyRi0DmkHAu8A2hi65hSMjFmHHlb5Azr5m/fTSsVHBj6LWX8B/2ygmtT4j q0nhYhqy26fS4JvXXHfk667JyubvDpHS8GfpCX7lQMvytlIeG0KacYAJi+W9IBsrtOIY bfPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature; bh=U+qTNJaSSVwTdCar1nMaVLBQkJLIa6dkmct+l7FiGIU=; b=cBWp3s0zgq2lMJixVA7BjDsEiwnsMYWCwYK+T5aq8/xUAJo1KmPTgU221BIT2ZDmmu xUmKV2s71YNdDU4j5VPTEg5dSaSTNmmOp1AAkmuI6Id/5vGCbLdRYKkxU4DCv2vDVmUf EAQAqxlI530HrRvZGIJdOL8z+qm4sJcoXy8u9RQSrp4FsBkOpHDFVFFPf/7idaLVW/RF x0ZPsTS0113vjf1eeGH+RA4dWtEjTdg/uZuZVW2MegYXj5rbbL6REOIpxPpO4J16SWix BnT2gLxuZ9owFRle/P4OA106XduUVxr7a4/CK/vMfmOOmuCOvcxbnriMlZHQFHJOFsO7 TVsQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b="LOIiqG/D"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b4si1438454ejg.366.2020.08.27.07.54.43; Thu, 27 Aug 2020 07:55:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b="LOIiqG/D"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727923AbgH0NPM (ORCPT + 99 others); Thu, 27 Aug 2020 09:15:12 -0400 Received: from mail29.static.mailgun.info ([104.130.122.29]:58527 "EHLO mail29.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727863AbgH0NN1 (ORCPT ); Thu, 27 Aug 2020 09:13:27 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1598534007; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=U+qTNJaSSVwTdCar1nMaVLBQkJLIa6dkmct+l7FiGIU=; b=LOIiqG/DNxJSOdtLlKjeEJ7gScMw/4pSZR1WWCAEjvqh1AXenphc8U2hQGtWrRW0AvEQPfRl X2yRxt7gNGpB8n1MLW/Lh9IeLs5BvMq7vKShPma+DFCmZ7qXORzAcp/R+mRsxisQjxZpGqU0 vnLtk0KQJd0Roliv/n+iEPvx+ds= X-Mailgun-Sending-Ip: 104.130.122.29 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-west-2.postgun.com with SMTP id 5f47b17415988fabe06a2e29 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 27 Aug 2020 13:13:24 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 63E99C433CB; Thu, 27 Aug 2020 13:13:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.5 required=2.0 tests=ALL_TRUSTED,MISSING_DATE, MISSING_MID,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 95756C433CA; Thu, 27 Aug 2020 13:13:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 95756C433CA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH 5.9] mt76: mt7915: use ieee80211_free_txskb to free tx skbs From: Kalle Valo In-Reply-To: <20200812144943.91974-1-nbd@nbd.name> References: <20200812144943.91974-1-nbd@nbd.name> To: Felix Fietkau Cc: linux-wireless@vger.kernel.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20200827131324.63E99C433CB@smtp.codeaurora.org> Date: Thu, 27 Aug 2020 13:13:24 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Felix Fietkau wrote: > Using dev_kfree_skb for tx skbs breaks AQL. This worked until now only > by accident, because a mac80211 issue breaks AQL on drivers with firmware > rate control that report the rate via ieee80211_tx_status_ext as struct > rate_info. > > Signed-off-by: Felix Fietkau > Acked-by: Toke Høiland-Jørgensen Patch applied to wireless-drivers.git, thanks. b4be5a53ebf4 mt76: mt7915: use ieee80211_free_txskb to free tx skbs -- https://patchwork.kernel.org/patch/11710923/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches