Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <61219c725630447e832839196e20eb433723ed49.camel@sipsolutions.net>
Subject: Re: [PATCH V5 4/5] mac80211: add support for BSS coloring
From:   Johannes Berg <johannes@sipsolutions.net>
To:     John Crispin <john@phrozen.org>
Cc:     linux-wireless@vger.kernel.org, ath11k@lists.infradead.org
Date:   Thu, 27 Aug 2020 14:26:18 +0200
In-Reply-To: <20200826055650.1101224-4-john@phrozen.org> (sfid-20200826_075710_318035_1DE9E6C8)
References: <20200826055650.1101224-1-john@phrozen.org>
         <20200826055650.1101224-4-john@phrozen.org>
         (sfid-20200826_075710_318035_1DE9E6C8)
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk


> + * @color_change_active: marks whether a color change is going on. Internally it is
> + *	write-protected by sdata_lock and local->mtx so holding either is fine
> + *	for read access.
> 

I started fixing up things like that but then I got annoyed and gave up
...

Just because checkpatch no longer warns on >80 columns that doesn't mean
it's suddenly completely acceptable to write very long lines. In flowed
text like this, it's much nicer to have shorter lines, and long lines
are just arbitrary.

That's actually in quite a few places in this patch - comments, function
arguments, etc.

Nothing against going over 80 where that makes the code more readable,
but long lines for flowed text are *less* readable.

johannes