Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp509977pxa; Thu, 27 Aug 2020 08:15:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzrD7Xi6a4NqhM/+2TlyvuR6GQTanvKaA4Lf8ner2NMs2rlTBBdALoKihxUCw5I7LvIDSLh X-Received: by 2002:a17:906:a209:: with SMTP id r9mr22597026ejy.413.1598541299816; Thu, 27 Aug 2020 08:14:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598541299; cv=none; d=google.com; s=arc-20160816; b=WFJi/CnTgEYr7eeDztWI9sVTaAQTGVz/angJ7j35n4DAV7qMQi2GzXjY3sZP+gEUbj KtQZ133MZ8Al4UPrV2mqGqxqC5f+leWHN8Cepn576vaBkp4Td84R8tzbdGqrgmipXAKm v3We68wsxTRoVxYc/xYgyAJHPcKOZh1IaBLItuScssaSw0LDuhTkpDWcyaBBzn7d17DC EzxRNwcH8hDHi36h6XYOinD7V8PKtb8xPYzZOFQ2zPXsuh2vq8sb4qD73G+rsiVMTWuw frQkaIqany+n44niaUxPaWMiPEDa0/uQRJpiAjnTh3xDHVDnM3DwsU9r4R7510r3MWY7 B3Sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=BBvKXX3aZrvi/soMwlwJEKnmyDLcsCYBgy11RwImob4=; b=YJfYKMLOqyEh5zuka+98AiAULZiPBP9ZlWcdFSSBdchi3OWUqINUbjnq16+hibfke6 gL98Uz+2ORWCooCFUWupQ46qRDQ/Ai5gVDP6bddqIxdlysEkxi+75Kduj4TO8cylmluW sZwvnznUTRiUMQyEMvgqS0FTVZk4IYrRydfoowV3GlDmYvGOM4pz9l5i0VsdjCMUz3mi 8VK/CBXBaL2xW6LE2oAY1xGFlLIuk/yhJwdxYeVVeRabnWAucDB60Gshcq4milf7E3f2 niA9nGM+ngrLxItWGkOuR8wlk53MQa1054sNdgYpUxx95zpS6gBc4i9S0ROaZqCy0i4C /j4w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d9si1732394edq.60.2020.08.27.08.14.34; Thu, 27 Aug 2020 08:14:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728216AbgH0PO3 (ORCPT + 99 others); Thu, 27 Aug 2020 11:14:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728329AbgH0Lia (ORCPT ); Thu, 27 Aug 2020 07:38:30 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71531C0611E2 for ; Thu, 27 Aug 2020 04:37:44 -0700 (PDT) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94) (envelope-from ) id 1kBGDq-00BZJz-VS; Thu, 27 Aug 2020 13:37:39 +0200 Message-ID: <208a211130e2bd2881e8c828feb0170db6a08a77.camel@sipsolutions.net> Subject: Re: [PATCH] iw: add TID specific Tx bitrate configuration From: Johannes Berg To: Tamizh Chelvam Cc: linux-wireless@vger.kernel.org Date: Thu, 27 Aug 2020 13:37:37 +0200 In-Reply-To: <1597903916-8674-1-git-send-email-tamizhr@codeaurora.org> References: <1597903916-8674-1-git-send-email-tamizhr@codeaurora.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Thu, 2020-08-20 at 11:41 +0530, Tamizh Chelvam wrote: > Add TID specific Tx bitrate configuration by using > handle_bitrates already APIs. In addition to what Sergey said, I get: interface.c: In function ‘handle_tid_config’: interface.c:944:11: warning: implicit conversion from ‘enum nl80211_tid_config_attr’ to ‘enum nl80211_attrs’ [-Wenum-conversion] 944 | NL80211_TID_CONFIG_ATTR_TX_RATE); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Please address that too. johannes