Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp902557pxa; Thu, 27 Aug 2020 20:22:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwgZLdZzM55stwqr9xprpB1AdQkVzbuu2DAll9Sj0wwYDk3KPsttL4njI3iSP4ydHyBU8sG X-Received: by 2002:a17:907:214e:: with SMTP id rk14mr25212866ejb.171.1598584961534; Thu, 27 Aug 2020 20:22:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598584961; cv=none; d=google.com; s=arc-20160816; b=UF+nHEMbm4vZkhe5VxiDGpo5XW2zT0aXEiecHLvoLOyRhPn+XoUBOJxHUYgJ6E2FTk q4owgioQQTL2I8LnUrZYtXY3h2GyKDgFgn7iqW2M4f3QZJOZCeYlINwLBSE9P+opPw0K ZHpDbHt1aA98ZNLWJG8qr11Uk7YJvqNofEt4gQ68JOvDEKuAqRTIyH4iA26yaUT28Tpc vsOczg8WFfY563kCDQW5UsQNMLw+46oMKbggixlZr4iHXVx7/Ir8zxyyHJ/zVCgqhXVm JoDfWyCLp3DQPiKu4/5Pesy8RtGweNLz2LLVosJjLKXmbgsYLuxovF7CJ6RR3/BOCYbz c1Jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:message-id:references :in-reply-to:subject:cc:to:from:date:content-transfer-encoding :mime-version:dkim-signature; bh=F7TvPtSUDXP1g1CLe1EeWey5ER9XS9KX4Ji30pM/v0w=; b=V0yU9laalPYwh72XnARN9BvP5a3SuKXhEQ9zZZmoHJVtgrmmVz4nD5Lf2xWv8LudQ0 ZXURJi+Pv+noXYIYnnnxQytRnxr84/C1jviglhwNEc+E4pj/UvoRZvIuDE61dfVtl4e3 MKuY/jyTPtiNcWBPO/8EWL/oQPxfCNr7WohCS4bSlEdYG8K4mqhTUI6dpTorg/PV94qe 59WapzJzn7Pmfa4AP8SAbcW8HZbH/rnKl5GYqc+lvkg/VbnndX4fO7+2dqciNR/pe58E ZIn7+KMbRJHk6di6sDyRPquzJYrufC7Q1WBtlgrhJUCaL5iudEmo1XVKsVrEkYzAsYO2 n2QA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=L1tKtqyg; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u13si2453939edp.336.2020.08.27.20.22.01; Thu, 27 Aug 2020 20:22:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=L1tKtqyg; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727954AbgH1DVn (ORCPT + 99 others); Thu, 27 Aug 2020 23:21:43 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:38253 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727817AbgH1DVn (ORCPT ); Thu, 27 Aug 2020 23:21:43 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1598584902; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=F7TvPtSUDXP1g1CLe1EeWey5ER9XS9KX4Ji30pM/v0w=; b=L1tKtqygqqxrOsPGeBqvHdXXDjFLwaMzvzulalub3JU2op5GgXyPSWazk73Yvs/Db0/TGble sJ8oayyNvB/p8CIauNE6gq4UxlHpbUzOh4tYCVPNg0WAjkeYlhDaZb7sg+dBwD5Q3FUPJ8ya ib/47LswWMKpZXe49Vo6kFKgr2k= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n03.prod.us-west-2.postgun.com with SMTP id 5f487819630b177c47ce5e12 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 28 Aug 2020 03:20:57 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 606A7C433CA; Fri, 28 Aug 2020 03:20:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: alokad) by smtp.codeaurora.org (Postfix) with ESMTPSA id F1D6AC433C6; Fri, 28 Aug 2020 03:20:56 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 27 Aug 2020 20:20:56 -0700 From: Aloka Dixit To: John Crispin Cc: Johannes Berg , linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-wireless-owner@vger.kernel.org Subject: Re: [PATCH V3 4/9] mac80211: add multiple bssid/ema support to bcn templating In-Reply-To: <20200812150050.2683396-5-john@phrozen.org> References: <20200812150050.2683396-1-john@phrozen.org> <20200812150050.2683396-5-john@phrozen.org> Message-ID: X-Sender: alokad@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org > +static void > +ieee80211_beacon_add_multiple_bssid_config(struct ieee80211_vif *vif, > struct sk_buff *skb, > + struct cfg80211_multiple_bssid_data *config) > +{ > + u8 *pos = skb_put(skb, 6); > + > + *pos++ = WLAN_EID_EXTENSION; > + *pos++ = 4; > + *pos++ = WLAN_EID_EXT_MULTIPLE_BSSID_CONFIGURATION; > + *pos++ = 2; > + *pos++ = vif->bss_conf.multiple_bssid.count; > + *pos++ = config->cnt; > +} > + Hi John, Which field in the IE is this line for : '*pos++ = 2;' ? This IE should be total 5 bytes with length=3.