Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@redhat.com>
To:     Felix Fietkau <nbd@nbd.name>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 6/9] mt76: rely on AQL for burst size limits on tx queueing
In-Reply-To: <20200831122558.1388-6-nbd@nbd.name>
References: <20200831122558.1388-1-nbd@nbd.name>
 <20200831122558.1388-6-nbd@nbd.name>
Date:   Mon, 31 Aug 2020 15:11:39 +0200
Message-ID: <87h7sjj6yc.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Felix Fietkau <nbd@nbd.name> writes:

> Now that AQL works well on all mt76 drivers,

Yay, great to hear! :)

> completely replace the arbitrary
> burst sizing and number of bursts logic for tx scheduling.
> For the short period of time in which AQL does not work well yet, limit each
> stations to 16 in-flight packets that have no estimated tx time.
> This should avoid filling the queue if a station connects and queues up a
> large number of packets before rate control information is available, especially
> with hardware rate control

I guess we could do accounting like this in the AQL mechanism itself?
Presumably this issue is not unique to mt76?

-Toke