Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] ath11k: Allow debugfs to work with 2+ radios installed.
To:     akolli@codeaurora.org
Cc:     ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
References: <20200903172359.29199-1-greearb@candelatech.com>
 <0101017459a1d409-4d95a8e1-d404-4fba-a25d-b2e3075947e0-000000@us-west-2.amazonses.com>
From:   Ben Greear <greearb@candelatech.com>
Organization: Candela Technologies
Message-ID: <d450eb2d-5c2d-c432-2cd5-b3121c7d27d4@candelatech.com>
Date:   Fri, 4 Sep 2020 08:34:38 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.11.0
MIME-Version: 1.0
In-Reply-To: <0101017459a1d409-4d95a8e1-d404-4fba-a25d-b2e3075947e0-000000@us-west-2.amazonses.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-MW
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 9/4/20 8:00 AM, akolli@codeaurora.org wrote:
> On 2020-09-03 22:53, greearb@candelatech.com wrote:
>> From: Ben Greear <greearb@candelatech.com>
>>
>> The code is trying to create an ath11k directory on debugfs
>> root, but that fails when there is a second radio (and thus
>> second instance of the driver).
>>
> 
> Hi Ben,
> 
> IPQ8074 is soc and it does not need second debugfs entry, its on AHB.
> QCA6390 is a pci card and multiple debug entries are needed if multiple cards are available,
> I am planning to post a patch with bus specific abstraction function which creates single debugfs for soc based radios and multiple entries for PCI based radios.
> 
> AHB:
> debugfs/ath11k/IPQ8074/
> 
> PCI
> debugfs/ath11k/QCA6390_0001:01:00.0/
> debugfs/ath11k/QCA6390_0000:01:00.0/

I appreciate your feedback on this!

Why not just stick with the way ath10k does, having the ath11k debugfs entry be
under the phy debugfs directory?

Maybe there is a high-level design document for the ath11k driver somewhere that
explains how and why it is architected with the ath11k base object holding multiple
phy objects?

And, very curious to know if you are able to get multiple QCA6390 NICs running on the
same system, I'm seeing all sort of problems including NICs not always showing up in lspci
and such.

Thanks,
Ben

> 
> Thanks
> Anil
> 


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com