Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Mon, 7 Sep 2020 11:01:52 +0000
From:   akolli@codeaurora.org
To:     Kalle Valo <kvalo@codeaurora.org>
Cc:     ath11k@lists.infradead.org, devicetree@vger.kernel.org,
        linux-wireless@vger.kernel.org
Subject: Re: [PATCH v6 3/3] ath11k: add IPQ6018 support
In-Reply-To: <87y2ll3nzh.fsf@codeaurora.org>
References: <1598287470-1871-1-git-send-email-akolli@codeaurora.org>
 <1598287470-1871-4-git-send-email-akolli@codeaurora.org>
 <87y2ll3nzh.fsf@codeaurora.org>
Message-ID: <01010174683ab719-82f5c599-a2e0-4697-9c14-9ce1c64608d5-000000@us-west-2.amazonses.com>
User-Agent: Roundcube Webmail/1.3.9
Feedback-ID: 1.us-west-2.CZuq2qbDmUIuT3qdvXlRHZZCpfZqZ4GtG9v3VKgRyF0=:AmazonSES
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 2020-09-07 15:30, Kalle Valo wrote:
> Anilkumar Kolli <akolli@codeaurora.org> writes:
> 
>> IPQ6018 has one 5G and one 2G radio with 2x2,
>> shares ipq8074 configurations.
>> 
>> Signed-off-by: Anilkumar Kolli <akolli@codeaurora.org>
> 
> [...]
> 
>> @@ -890,9 +995,15 @@ static int ath11k_ahb_probe(struct 
>> platform_device *pdev)
>>  		goto err_hal_srng_deinit;
>>  	}
>> 
>> -	ab->hw_params.svc_to_ce_map_len =
>> +	if (ab->hw_rev == ATH11K_HW_IPQ8074) {
>> +		ab->hw_params.svc_to_ce_map_len =
>>  			ARRAY_SIZE(target_service_to_ce_map_wlan_ipq8074);
>> -	ab->hw_params.svc_to_ce_map = target_service_to_ce_map_wlan_ipq8074;
>> +		ab->hw_params.svc_to_ce_map = 
>> target_service_to_ce_map_wlan_ipq8074;
>> +	} else if (ab->hw_rev == ATH11K_HW_IPQ6018) {
>> +		ab->hw_params.svc_to_ce_map_len =
>> +			ARRAY_SIZE(target_service_to_ce_map_wlan_ipq6018);
>> +		ab->hw_params.svc_to_ce_map = 
>> target_service_to_ce_map_wlan_ipq6018;
>> +	}
> 
> The idea of having ab->hw_params is to avoid the need for hw_rev
> sprinkled all over the code, this here defeats the purpose. I recommend
> checking if my proposal from an earlier version is implementable:
> 
> "You could copy the map arrays to hw.c, as an example see how
>  ath11k_hw_ring_mask_ipq8074 is implemented. That way we don't need any
>  new hw_rev checks."

Thanks for the details, will address and send in next patch set.

Thanks
Anil