Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp957028pxk; Thu, 10 Sep 2020 03:16:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwM8FyoexnTy/ncFupyuaqhlG6wFP1uyy8+xEEsTXxWxtsDcsAoYIgoPQ5lmsJtol+DVPNH X-Received: by 2002:a17:906:1b15:: with SMTP id o21mr7837062ejg.377.1599733005040; Thu, 10 Sep 2020 03:16:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599733005; cv=none; d=google.com; s=arc-20160816; b=oWKKYaeaNykU6FXSmd5cBqmkiYg+Jdm+EmbcaeBs4v0iXNAtjkxnX6u04rdGKV1Iqn gfBO0x6BWi1v9/Dt10wD7a2t/4KRaMf2yIlXgZGh7RxUgNfH8rovnI9ZUTlzBM3KJjFI jUsJfbIEyFTMwiuOuaPLfn2v78TJOY/739+vG9rLblJlbyPJrwcDfFxKXWgYwaaGs6ag ncwuRZ9r5K0+jUQtjV+giuzLfjhszNmWRamruWLdycSmgKOw+/33BaJlulXCk+4+iNnO EW9OZflYBhJ0T6sU2H1SdNnzH6edVYx60yQcn3UhS6ij3wvRbcimI9umaPjuOyFgBYq2 71Iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:dkim-signature; bh=+GdI4nxZ45re4YvFQZdBwKgPlubeZww9U/bSQOsUDPc=; b=l6bV8Li07mUR/uJOk7qfjlAvqu21T3Yg2St7/hyW5zkU6/tgeg5w/RJR1DAFCB5G/J Iw9dMnvv2zwea5skTM9CO3yEew76iiOkLpw68KrQr2oBkA4KakWv3sjfyFcgsarZysyX jHwtkdtTKJ4J9uJhS0dh/G6sVNyMesOOE0eOmaa0D8vrb5lccO8nYtILVS3CM7MuNFLL 8dvsHmgsoRoUMjXN3b7I0diPwjPzzKGSH0ZMwVpqwaKZtbdH7wIaH8O6XGMQNd9E33ix sxKYhUs6z0JGyf18GVh6JURtcS198dMIREBJIr8oqpY3WQGAQI9OXSBs9gajkDYJTHTS Du8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=cvP50EMR; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cz6si3931644edb.142.2020.09.10.03.16.10; Thu, 10 Sep 2020 03:16:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=cvP50EMR; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730315AbgIJKNa (ORCPT + 99 others); Thu, 10 Sep 2020 06:13:30 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:37624 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730556AbgIJKNY (ORCPT ); Thu, 10 Sep 2020 06:13:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599732802; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+GdI4nxZ45re4YvFQZdBwKgPlubeZww9U/bSQOsUDPc=; b=cvP50EMRS4wAUyjx2QzaRFCNdIv22jmtAG/faQR2hIKrYj+d92OornbKy0KtKFB1VJuxha DB9J3DIAE/wl5wUi7vLWg8GJt2GRHZU3YvWYTrbtVoMDyoaillpitTkLsrP07W7tEoNMyK ACpDdkrALRAdKjbEpohIl1/aUrH7XmE= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-369-d9Ea8ZTXOyK-lLcXhNuqKQ-1; Thu, 10 Sep 2020 06:13:20 -0400 X-MC-Unique: d9Ea8ZTXOyK-lLcXhNuqKQ-1 Received: by mail-wr1-f72.google.com with SMTP id i10so2075357wrq.5 for ; Thu, 10 Sep 2020 03:13:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=+GdI4nxZ45re4YvFQZdBwKgPlubeZww9U/bSQOsUDPc=; b=XijFsu6sOG3pq8Cfyt9Ug+BHwJB384owhfUPOS97GwHRPhecis6gYP9OJeY6QX7swt GCSjmXYUfhD1719yHqIK1j53eUkNdcWNvlP1FkZAUVRe82hF27sJ2SD2ghR235+6O6xS NbEB/QNyVnK9kcrxtMrZluz7UKJ2Qb6Agx8yEBZ2BQDnRiUtymeyJGlnKHf/mMYerqTR RcwZLrljk1KDSwTv6UedpHAV9LeASTg34TNcDPwgyg+eF5988Vn65bzyDYiPJ6iTl5TF geeAUkvc+c+r7xkW3zvGMxb4fC4AJEkcQLgqhMkw8ZRsGktjvkLbiLDRtxPZZ+IdiTuq Ja/Q== X-Gm-Message-State: AOAM532ruwhGXPEeQSYRr7C5QYaAfOVRGbVlelzIe0LJv9dO5kX/FFlZ em2zWm7aijMWin486X6CMvU8AWANYbP9N+Gyo65Q4xJ8ZpDKz18fWzMcbQpur/+UBgs2PAH2zX9 2G2PaAqTbpZLTlFuT6ZhnkYOy2Y4= X-Received: by 2002:a05:600c:2f8f:: with SMTP id t15mr8084703wmn.41.1599732799085; Thu, 10 Sep 2020 03:13:19 -0700 (PDT) X-Received: by 2002:a05:600c:2f8f:: with SMTP id t15mr8084665wmn.41.1599732798651; Thu, 10 Sep 2020 03:13:18 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([2a0c:4d80:42:443::2]) by smtp.gmail.com with ESMTPSA id e18sm8372557wrx.50.2020.09.10.03.13.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Sep 2020 03:13:18 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 7EC941829D4; Thu, 10 Sep 2020 12:13:17 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Felix Fietkau , linux-wireless@vger.kernel.org Cc: johannes@sipsolutions.net Subject: Re: [PATCH 5.9 1/2] mac80211: extend AQL aggregation estimation to HE and fix unit mismatch In-Reply-To: <20200909115602.21783-1-nbd@nbd.name> References: <20200909115602.21783-1-nbd@nbd.name> X-Clacks-Overhead: GNU Terry Pratchett Date: Thu, 10 Sep 2020 12:13:17 +0200 Message-ID: <87ft7qaqiq.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Felix Fietkau writes: > The unit of the return value of ieee80211_get_rate_duration is nanoseconds, not > milliseconds. s/milli/micro/ here, no? > Adjust the duration checks to account for that. > For higher data rates, allow larger estimated aggregation sizes, and add some > values for HE as well, which can use much larger aggregates. > Since small packets with high data rates can now lead to duration values too > small for info->tx_time_est, return a minimum of 4us. Fixes: tag? -Toke