Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp108593pxk; Fri, 11 Sep 2020 01:37:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyyJckdkuQNXZ2ZpnrNDZzMUaEG3qEFiZpsisRPIXMGMWoD+LW8QK37GuO7nAYAoAFYDZMk X-Received: by 2002:aa7:d750:: with SMTP id a16mr907998eds.362.1599813426610; Fri, 11 Sep 2020 01:37:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599813426; cv=none; d=google.com; s=arc-20160816; b=aeS2BYhuwsGxsnzYqya2jZpcgCawvLD5XlH67ktPQ97Du2JrDdra16+2FypGJGtcZA fA+CcWFU8Rhhp+HBjIvTqM/L4B0KTIriCdI8zBmZBfme41Nk1jMY94D0Tk8/D6hWDCpE WE7jBFAgq4rfgp37jzEs/vgG5LGnnuUCHcq88pTOV8Xg9C5X/nnq3aYre+msxQWihddb swytwiE0Mv7t3HHWluIAXGwUvoL0apw0g4Rxx7AGdVGuQsba8F0w8MzAweQSyT/89Nue c91iAI0gkoPDBzPTFw8ON5ht2VtfPZeTYcI/5SqyzmX8ZxSQwaSLYKC5PKFzYzmUsZRW D+lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:feedback-id:mime-version:user-agent :message-id:in-reply-to:date:references:subject:cc:to:from :dmarc-filter:dkim-signature:dkim-signature; bh=oU0I8mL6qqWDBZzK9Jc+v7q/E4wmBqTpVepI3EvxmHQ=; b=a7iJ99zF6rhkPN4bxTld/j0l3Vn3Rrz58X5SjAtLxQzXBeaJyWfVk4oGS80CI7Vh16 FkluDnf++gKN0cvFpJUuOHMKVUca8WO4sppVCnqyyV5ZOQmuOkOloBxFjfVUHBuVBiy7 sM8vn9ldm/EAjcsgUsLzWiVes4CcIpJBGH7m0g4EEEi0tN0En1dzUevVum620cacvjeK 3vuabNVZgJmhZP/xiF6oovjKr/cDaxxn3LPEaGk6imAyG90WxMdTuJoIOI9TBOMEWFEu drkmgwKOtFRlayFVg+k5XPLMiTKrV9UiXEQe04UyKtcye0tOQ56+T8n0g9+rZfjn2r7/ BTOA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=zsmsymrwgfyinv5wlfyidntwsjeeldzt header.b=cIu6Q577; dkim=pass header.i=@amazonses.com header.s=hsbnp7p3ensaochzwyq5wwmceodymuwv header.b="ZwLa/n+O"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a5si795157edt.556.2020.09.11.01.36.33; Fri, 11 Sep 2020 01:37:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=zsmsymrwgfyinv5wlfyidntwsjeeldzt header.b=cIu6Q577; dkim=pass header.i=@amazonses.com header.s=hsbnp7p3ensaochzwyq5wwmceodymuwv header.b="ZwLa/n+O"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725730AbgIKIfj (ORCPT + 99 others); Fri, 11 Sep 2020 04:35:39 -0400 Received: from a27-21.smtp-out.us-west-2.amazonses.com ([54.240.27.21]:41004 "EHLO a27-21.smtp-out.us-west-2.amazonses.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725766AbgIKIfg (ORCPT ); Fri, 11 Sep 2020 04:35:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=zsmsymrwgfyinv5wlfyidntwsjeeldzt; d=codeaurora.org; t=1599813335; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID:MIME-Version:Content-Type; bh=xiW9+cCWE9me7Zc3FisQVRQMgzbSxsWOHcsDu+W+kiY=; b=cIu6Q577NQemacxNZyNCMCQA/KbqzQRWfv9t0xKHNw4KW8Gl1lF5J5MQoxhkUL83 DziGwY4/VUgFG6gQUT8zc7y2hn4/mAm1MQV9Sy2Ucx8+b4fZ7e7d1d67XXfe++WS7Mz kwhaRw1mWjgV1w0/IvXbGbXGJDMSbGMw23WFYUZo= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=hsbnp7p3ensaochzwyq5wwmceodymuwv; d=amazonses.com; t=1599813335; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID:MIME-Version:Content-Type:Feedback-ID; bh=xiW9+cCWE9me7Zc3FisQVRQMgzbSxsWOHcsDu+W+kiY=; b=ZwLa/n+OQeZj76o5306xGVjg2cM+QZCyXS0PvBmfe9bLHoEHEN6NZL+BlUQjRLgZ 2++yCt7/Q0hdWVWN9trpjQ1RTw9IG/ea6fkiCpaAKjFExKqKoJWzVk1Om4xPhZTflXV GFA5vofg/TIyhYhzRy5bqeV7je05ePWm4gmFrVb8= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00,SPF_FAIL, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 9984AC433CA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Ben Greear Cc: "linux-wireless\@vger.kernel.org" , Wen Gong , ath10k@lists.infradead.org Subject: Re: lockdep splat in kvallo ath tree References: <0ef69472-9613-c265-0635-ff2ef0cf274f@candelatech.com> Date: Fri, 11 Sep 2020 08:35:35 +0000 In-Reply-To: <0ef69472-9613-c265-0635-ff2ef0cf274f@candelatech.com> (Ben Greear's message of "Wed, 2 Sep 2020 15:54:31 -0700") Message-ID: <010101747c4e398e-cdd20756-ad3b-42dd-8db3-341c9bf5880e-000000@us-west-2.amazonses.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SES-Outgoing: 2020.09.11-54.240.27.21 Feedback-ID: 1.us-west-2.CZuq2qbDmUIuT3qdvXlRHZZCpfZqZ4GtG9v3VKgRyF0=:AmazonSES Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org + ath10k Ben Greear writes: > The patch below adds a call to ath10k_debug_fw_stats_request(ar), > which expects ar->conf_mutex to be held, but it is *not* held in > this code path. This leads to warnings when lockdep is enabled. > > > greearb@bendt7 ath10k]$ git show 4913e675630ec > commit 4913e675630ec1a15c92651f426a63755c71b91b > Author: Wen Gong > Date: Thu Apr 23 10:27:58 2020 +0800 > > ath10k: enable rx duration report default for wmi tlv > > When run command "iw dev wlan0 station dump", the rx duration is 0. > When firmware indicate WMI_UPDATE_STATS_EVENTID, extended flag of > statsis not set by default, so firmware do not report rx duration. Wen, please investigate this. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches