Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Fri, 11 Sep 2020 20:50:46 +0000
From:   Aloka Dixit <alokad@codeaurora.org>
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     linux-wireless@vger.kernel.org,
        linux-wireless-owner@vger.kernel.org
Subject: Re: [PATCH] mac80211: Fix radiotap header channel flag for 6GHz band
In-Reply-To: <1cc7242cd00cd5141a56f17a7f5c80700485aa39.camel@sipsolutions.net>
References: <010101747ab7b9c0-45fa1c2a-3bb5-44e8-8e6d-457cad2e9845-000000@us-west-2.amazonses.com>
 <1cc7242cd00cd5141a56f17a7f5c80700485aa39.camel@sipsolutions.net>
Message-ID: <010101747eef4de4-f80bae2e-6ab2-48c5-bc89-bf21e5ac41fc-000000@us-west-2.amazonses.com>
User-Agent: Roundcube Webmail/1.3.9
Feedback-ID: 1.us-west-2.CZuq2qbDmUIuT3qdvXlRHZZCpfZqZ4GtG9v3VKgRyF0=:AmazonSES
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 2020-09-11 00:36, Johannes Berg wrote:
> On Fri, 2020-09-11 at 01:11 +0000, Aloka Dixit wrote:
>> Radiotap header field 'Channel flags' has '2 GHz spectrum' set to
>> 'true' for 6GHz packet.
>> Change it to 5GHz as there isn't a separate option available for 6GHz.
>> 
>> Signed-off-by: Aloka Dixit <alokad@codeaurora.org>
>> ---
>>  net/mac80211/rx.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>> 
>> diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c
>> index 836cde516a18..a959ebf56852 100644
>> --- a/net/mac80211/rx.c
>> +++ b/net/mac80211/rx.c
>> @@ -451,7 +451,8 @@ ieee80211_add_rx_radiotap_header(struct 
>> ieee80211_local *local,
>>  	else if (status->bw == RATE_INFO_BW_5)
>>  		channel_flags |= IEEE80211_CHAN_QUARTER;
>> 
>> -	if (status->band == NL80211_BAND_5GHZ)
>> +	if (status->band == NL80211_BAND_5GHZ ||
>> +	    status->band == NL80211_BAND_6GHZ)
>>  		channel_flags |= IEEE80211_CHAN_OFDM | IEEE80211_CHAN_5GHZ;
> 
> I guess we should just not set any of those flags?
> 
> Not that anything even cares ... so there's no point in adding a 6GHz
> flag to radiotap.
> 
> johannes

Separate flag for 6GHz would have been best option, but I still think 
better to set 5GHz as 6GHz frequencies start in 5GHz range.
Thanks.