Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp754119pxk; Fri, 11 Sep 2020 22:08:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxLRbh5f18kppPVjSVRC47u1bO8fiiFnRepICHr869ULyyLsLPNHb7j1ArhaKGGYJU2rcvh X-Received: by 2002:a17:906:850:: with SMTP id f16mr4845222ejd.447.1599887291984; Fri, 11 Sep 2020 22:08:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599887291; cv=none; d=google.com; s=arc-20160816; b=vuTzsCpWTAJB8wSGrZpnxwgUZyL0uQ6+facFodoWLeT8yEOchxf6BBkg6QOeY+wG/R twzY/ByLpcD74c4Z3KrsjUlOVUxD+Fm8sP6xZKVTkDS/s+bchjl+0LsWv2eIUKVIfp6B eTKs8c4PuNG3ptsTGFN20LLb/HhV3+IrCYUaQdW2ZT5CA0ZzEolG1bN/GeXiHJ/ivcGu 3TDD1XFKu4fwQiUz8QBciVUZCad0GOIXszwjdRPXXfBDN/SC+t/nbG1GvuBimOnxf6Ko CcwUqT0JgifMwO0KYpRGn1BYglRD0tKKkrDrVA/z8jfrBvJbT43QWN7MLPasC4q5AkEw 6xAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:dkim-signature; bh=bEA8PH8QhQi8OkoE0BDoZ6+6iBHy/JwJCBgkwNfvOT0=; b=FRG1VOkU/Y4+Y/LHKy/saUz2g53dJvVAwgB50rLZwUNm1v60zNnZlhXc8niXu9L9Ni ao1zlUMJgMHp5VRgSrWi/mHpX79P7K812MPg6epTfIEKADISw5+LXgWPaF6YnqvEYlr7 DML+9X/ODU6bGXpdZKx2PRE9qwVHsBHvRrdn6x8ELqHJGByLnoPpL/kR8Adify83KtM8 4iz+PUOW32u3ywMxCQZLOd/A9WV1lQ0e/cfT74zepGdUXIR46e9kBpGTraRm6uetKESc DdI5obgV55qrMDmqZWxeNiTc5TXzl7dMgJoDqwXo0TEbhYHP9nB+SXJq850nVV8AClVM CpjA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=YbIO94EO; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x24si2653658eju.477.2020.09.11.22.07.47; Fri, 11 Sep 2020 22:08:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=YbIO94EO; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725805AbgILFGp (ORCPT + 99 others); Sat, 12 Sep 2020 01:06:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725797AbgILFGo (ORCPT ); Sat, 12 Sep 2020 01:06:44 -0400 Received: from nbd.name (nbd.name [IPv6:2a01:4f8:221:3d45::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D873C061573 for ; Fri, 11 Sep 2020 22:06:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=bEA8PH8QhQi8OkoE0BDoZ6+6iBHy/JwJCBgkwNfvOT0=; b=YbIO94EO+SQ363+P2vkesoHCVn Nj/3+vAvZzRePBy7TmDLVd7JZ9Vsq6NFr9W7XBVO/XQFjbm2NPHpvFCR05kN9gMZz09u9RziKNseJ eCi2ENE/5x1gWkXApLpNcc3qKN3QEJk2kM54t/6q1MRkPeNY+kSMFsnv0nW0XWu8M9E8=; Received: from p4ff13fcb.dip0.t-ipconnect.de ([79.241.63.203] helo=nf.local) by ds12 with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1kGxkH-0006UN-QX; Sat, 12 Sep 2020 07:06:41 +0200 Subject: Re: [PATCH 5.9 1/2] mac80211: extend AQL aggregation estimation to HE and fix unit mismatch To: =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= , linux-wireless@vger.kernel.org Cc: johannes@sipsolutions.net References: <20200909115602.21783-1-nbd@nbd.name> <87ft7qaqiq.fsf@toke.dk> From: Felix Fietkau Autocrypt: addr=nbd@nbd.name; prefer-encrypt=mutual; keydata= xsDiBEah5CcRBADIY7pu4LIv3jBlyQ/2u87iIZGe6f0f8pyB4UjzfJNXhJb8JylYYRzIOSxh ExKsdLCnJqsG1PY1mqTtoG8sONpwsHr2oJ4itjcGHfn5NJSUGTbtbbxLro13tHkGFCoCr4Z5 Pv+XRgiANSpYlIigiMbOkide6wbggQK32tC20QxUIwCg4k6dtV/4kwEeiOUfErq00TVqIiEE AKcUi4taOuh/PQWx/Ujjl/P1LfJXqLKRPa8PwD4j2yjoc9l+7LptSxJThL9KSu6gtXQjcoR2 vCK0OeYJhgO4kYMI78h1TSaxmtImEAnjFPYJYVsxrhay92jisYc7z5R/76AaELfF6RCjjGeP wdalulG+erWju710Bif7E1yjYVWeA/9Wd1lsOmx6uwwYgNqoFtcAunDaMKi9xVQW18FsUusM TdRvTZLBpoUAy+MajAL+R73TwLq3LnKpIcCwftyQXK5pEDKq57OhxJVv1Q8XkA9Dn1SBOjNB l25vJDFAT9ntp9THeDD2fv15yk4EKpWhu4H00/YX8KkhFsrtUs69+vZQwc0cRmVsaXggRmll dGthdSA8bmJkQG5iZC5uYW1lPsJgBBMRAgAgBQJGoeQnAhsjBgsJCAcDAgQVAggDBBYCAwEC HgECF4AACgkQ130UHQKnbvXsvgCgjsAIIOsY7xZ8VcSm7NABpi91yTMAniMMmH7FRenEAYMa VrwYTIThkTlQzsFNBEah5FQQCACMIep/hTzgPZ9HbCTKm9xN4bZX0JjrqjFem1Nxf3MBM5vN CYGBn8F4sGIzPmLhl4xFeq3k5irVg/YvxSDbQN6NJv8o+tP6zsMeWX2JjtV0P4aDIN1pK2/w VxcicArw0VYdv2ZCarccFBgH2a6GjswqlCqVM3gNIMI8ikzenKcso8YErGGiKYeMEZLwHaxE Y7mTPuOTrWL8uWWRL5mVjhZEVvDez6em/OYvzBwbkhImrryF29e3Po2cfY2n7EKjjr3/141K DHBBdgXlPNfDwROnA5ugjjEBjwkwBQqPpDA7AYPvpHh5vLbZnVGu5CwG7NAsrb2isRmjYoqk wu++3117AAMFB/9S0Sj7qFFQcD4laADVsabTpNNpaV4wAgVTRHKV/kC9luItzwDnUcsZUPdQ f3MueRJ3jIHU0UmRBG3uQftqbZJj3ikhnfvyLmkCNe+/hXhPu9sGvXyi2D4vszICvc1KL4RD aLSrOsROx22eZ26KqcW4ny7+va2FnvjsZgI8h4sDmaLzKczVRIiLITiMpLFEU/VoSv0m1F4B FtRgoiyjFzigWG0MsTdAN6FJzGh4mWWGIlE7o5JraNhnTd+yTUIPtw3ym6l8P+gbvfoZida0 TspgwBWLnXQvP5EDvlZnNaKa/3oBes6z0QdaSOwZCRA3QSLHBwtgUsrT6RxRSweLrcabwkkE GBECAAkFAkah5FQCGwwACgkQ130UHQKnbvW2GgCfTKx80VvCR/PvsUlrvdOLsIgeRGAAn1ee RjMaxwtSdaCKMw3j33ZbsWS4 Message-ID: <378196df-d302-4a24-b772-30b7243b9358@nbd.name> Date: Sat, 12 Sep 2020 07:06:41 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <87ft7qaqiq.fsf@toke.dk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2020-09-10 12:13, Toke Høiland-Jørgensen wrote: > Felix Fietkau writes: > >> The unit of the return value of ieee80211_get_rate_duration is nanoseconds, not >> milliseconds. > > s/milli/micro/ here, no? Right. >> Adjust the duration checks to account for that. >> For higher data rates, allow larger estimated aggregation sizes, and add some >> values for HE as well, which can use much larger aggregates. >> Since small packets with high data rates can now lead to duration values too >> small for info->tx_time_est, return a minimum of 4us. > > Fixes: tag? Will add it and send v2. Thanks, - Felix