Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 76251C433C6
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Wright Feng <wright.feng@cypress.com>
Cc:     linux-wireless@vger.kernel.org, brcm80211-dev-list@broadcom.com,
        brcm80211-dev-list@cypress.com,
        Arend van Spriel <arend.vanspriel@broadcom.com>,
        Franky Lin <franky.lin@broadcom.com>,
        Hante Meuleman <hante.meuleman@broadcom.com>,
        chi-hsien.lin@cypress.com, Kurt Lee <kurt.lee@cypress.com>
Subject: Re: [PATCH v2 2/3] brcmfmac: set net carrier on via test tool for AP mode
References: <20200914031634.190721-1-wright.feng@cypress.com>
        <20200914031634.190721-3-wright.feng@cypress.com>
Date:   Mon, 14 Sep 2020 11:20:46 +0300
In-Reply-To: <20200914031634.190721-3-wright.feng@cypress.com> (Wright Feng's
        message of "Sun, 13 Sep 2020 22:16:33 -0500")
Message-ID: <87v9ggojkx.fsf@codeaurora.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Wright Feng <wright.feng@cypress.com> writes:

> From: Kurt Lee <kurt.lee@cypress.com>
>
> In manufacturing line, test tool may be used to enable SoftAP. Such
> SoftAP can't pass traffic because netif carrier is off by default. To
> allow such use case, let brcmfmac parse ioctl cmd, and then set iftype
> to ap mode and report netif_carrier_on to upper layer.

nl80211 does not use ioctl(), so the commit log is misleading.

> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/vendor.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/vendor.c
> @@ -64,6 +64,15 @@ static int brcmf_cfg80211_vndr_cmds_dcmd_handler(struct wiphy *wiphy,
>  		*(char *)(dcmd_buf + len)  = '\0';
>  	}
>  
> +	if (cmdhdr->cmd == BRCMF_C_SET_AP) {
> +		if (*(int *)(dcmd_buf) == 1) {
> +			ifp->vif->wdev.iftype = NL80211_IFTYPE_AP;
> +			brcmf_net_setcarrier(ifp, true);
> +		} else {
> +			ifp->vif->wdev.iftype = NL80211_IFTYPE_STATION;
> +		}
> +	}

We now have rules for the vendor API:

https://wireless.wiki.kernel.org/en/developers/documentation/nl80211#vendor-specific_api

As the BRCMF_VNDR_CMDS_DCMD just seems to be a simple pipe between the
user space and the firmware I'm leaning towards that we should just
remove support for that command from brcmfmac.

And besides, for factory tests you should be using NL80211_CMD_TESTMODE.
The vendor API is meant for normal mode usage.


-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches