Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp2791739pxk; Tue, 15 Sep 2020 02:25:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxqFsQQObQwCpBD7fsr851OjWYTn4RXuY/W0XCQttBEzTFpMPvSOwcwgkhngBPKOkBmVA1g X-Received: by 2002:aa7:dc16:: with SMTP id b22mr21135698edu.252.1600161929649; Tue, 15 Sep 2020 02:25:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600161929; cv=none; d=google.com; s=arc-20160816; b=WTXS/TTkc8i+KGpAlrPxj26VlJsw81lo2sYFWro4laIk5KZIH9beqP7gJpkOxvG+Rw i1CCG/Gv/Qwa6WknyerhaYko5oTn1fMKkLMuWpa6ta8v0AulZ5oUBV2h9n7+gbLqCMWO JvxKSv7L7o11PscQF0IO52aY8YC2Sx0fvihUY9u2q8ZoUQwCrRAkVg7MiKih37JHuHw+ G5wjqdzVjf8N6KZ6DRBPO+okRVnaPLzVRNy1tHJx1FXwXaiXNDpvTG5lbDLjx6zY6UKk EkO+o285Wc/P6Z5jzpm55qmw19q8vV3EqO57slC0/4Jf3Un0hrJcdmQajQClJNyvvfNI hNiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:references:in-reply-to:subject:cc:to:from :dkim-signature; bh=KgzAfLaizeZBqh6WYgvqowvlbuexG/f+F8PiYy1ltEs=; b=z8Ujtcmz7rXtJA1dcSNxUOUdsswUwL1nJeOImvsqDKKCZ2n/C7A7+3fGXxj9rBJYn1 6Ei5uuAWB7z4bUHke63Bdcv9WtQHErCnw8Y2IFmBR3bpT3nYlmN8cXMCNjvb/5RLRcp5 Ja1alUYtQV4GuRg2M+fSvU8OGD6jhk0CfOia5/IXG/ROK4I5WVQ1jPi/5Ci/g6sPPGPG yI8kQGtcFSJ2Houdtqa8u6zuhWzJGGM2uCg3q6zfP42crNunXONpQKGFSMg8xMWlentn BeeROM8VS5aWBZ5UuW6k/t18n22Knw7J1E+NFXv9ujiZd++Lr5J6w2QjRrZAhj+MDqXA ZkEQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=FZ9CtRVF; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dk26si8953156edb.60.2020.09.15.02.25.05; Tue, 15 Sep 2020 02:25:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=FZ9CtRVF; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726130AbgIOJYk (ORCPT + 99 others); Tue, 15 Sep 2020 05:24:40 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:45247 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726102AbgIOJYi (ORCPT ); Tue, 15 Sep 2020 05:24:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600161876; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KgzAfLaizeZBqh6WYgvqowvlbuexG/f+F8PiYy1ltEs=; b=FZ9CtRVF3T6F6d7sJCPCGScnVXJWnzFlrUz2gfD5I6CxRoWr6v3jEl34Ne2DTcLt4fmBie grIuVTWFMj6yYzfLzStlfo57Sif5XUxwcSKaSCgBP9hyVenHJWsAg59xH0Qx64SVfpCd03 UDWkhbF4JvXSXEOArSLFbfCW6fbYiFM= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-534-bnrTOF5kPyiiMrXqnbIS4g-1; Tue, 15 Sep 2020 05:24:34 -0400 X-MC-Unique: bnrTOF5kPyiiMrXqnbIS4g-1 Received: by mail-wr1-f69.google.com with SMTP id v12so994621wrm.9 for ; Tue, 15 Sep 2020 02:24:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=KgzAfLaizeZBqh6WYgvqowvlbuexG/f+F8PiYy1ltEs=; b=j/nK9REPPQWogyqKOPfXhZQE+2yeV56zsbwLzC/aJgTGA9UrKfZ8ZeUDK8iqWJWuIq iCbUUQn4DeQpeCSiSlisDq8m36aLIh7d1rQnezlalktM1yLT+tQNVS7Uvlkpi/xoJzEE TkxnLywB75800TnMEOtAxrsmBdgkff3dMrvJ+sKz0ExoHFKX+JOs12U7fSoIpuTVbsrR 7J5Xoz4khiqy49mZTblfrVEpPVrRpRuN32haUkGvL6tRoFFj49mKUS+6n0r5MMPhY/nw IZ3C136XS/HH1XLnsqRBIzlnsZVpo29SDzw8zICe95637kfyiEDTgFKYNkG71kXLWow8 k/4A== X-Gm-Message-State: AOAM530qsmEuGoZOmHN/it4gn7yHUMM5cL4lC+Jpdk/kri2BN6pd19VK uIjTaWlvUZdAv2gy7h2/JQnjR9rHLsEydDwQdw+w21J91iFyfA9uCOBDBCS1o4mS7A3eIBLLjU6 gCYDAj8yUmmHzFyt9xIauXS4Xass= X-Received: by 2002:a05:600c:2257:: with SMTP id a23mr3871616wmm.102.1600161873367; Tue, 15 Sep 2020 02:24:33 -0700 (PDT) X-Received: by 2002:a05:600c:2257:: with SMTP id a23mr3871587wmm.102.1600161873004; Tue, 15 Sep 2020 02:24:33 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([2a0c:4d80:42:443::2]) by smtp.gmail.com with ESMTPSA id i11sm25856565wre.32.2020.09.15.02.24.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2020 02:24:32 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 0B22B1829CB; Tue, 15 Sep 2020 11:24:31 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Felix Fietkau , linux-wireless@vger.kernel.org Cc: johannes@sipsolutions.net Subject: Re: [PATCH 5.9 v2 1/2] mac80211: extend AQL aggregation estimation to HE and fix unit mismatch In-Reply-To: <20200915085945.3782-1-nbd@nbd.name> References: <20200915085945.3782-1-nbd@nbd.name> X-Clacks-Overhead: GNU Terry Pratchett Date: Tue, 15 Sep 2020 11:24:30 +0200 Message-ID: <87d02nz92p.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Felix Fietkau writes: > The unit of the return value of ieee80211_get_rate_duration is nanosecond= s, not > microseconds. Adjust the duration checks to account for that. > For higher data rates, allow larger estimated aggregation sizes, and add = some > values for HE as well, which can use much larger aggregates. > Since small packets with high data rates can now lead to duration values = too > small for info->tx_time_est, return a minimum of 4us. > > Fixes: f01cfbaf9b29 ("mac80211: improve AQL aggregation estimation for lo= w data rates") > Signed-off-by: Felix Fietkau Acked-by: Toke H=C3=B8iland-J=C3=B8rgensen