Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <e122ae9b058e6f8c7c82d6ebef90517a604a3c64.camel@sipsolutions.net>
Subject: Re: [PATCH] mac80211: allow bigger A-MSDU sizes in VHT, even if HT
 is limited
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Felix Fietkau <nbd@nbd.name>, linux-wireless@vger.kernel.org
Date:   Wed, 16 Sep 2020 19:44:57 +0200
In-Reply-To: <20200916164611.8022-1-nbd@nbd.name>
References: <20200916164611.8022-1-nbd@nbd.name>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Wed, 2020-09-16 at 18:46 +0200, Felix Fietkau wrote:
> Some APs (e.g. Asus RT-AC88U) have been observed to report an HT MSDU size
> limit of 3839 and a VHT limit of 7991. These APs can handle bigger frames
> than 3839 bytes just fine, so we should remove the VHT limit based on the
> HT capabilities. This improves tx throughput.

I'm not really convinced that we can do this, since we don't track
HT/VHT limits separately.

IOW, to be behaving according to the AP you mention, we'd have to know
when building an A-MSDU whether it's going to use HT or VHT rates, but
we don't track that at all ...

johannes