Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 4839EC433C8
From:   Kalle Valo <kvalo@codeaurora.org>
To:     greearb@candelatech.com
Cc:     ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath11k:  Support loading ELF board files.
References: <20200826232044.6799-1-greearb@candelatech.com>
Date:   Wed, 16 Sep 2020 17:21:57 +0300
In-Reply-To: <20200826232044.6799-1-greearb@candelatech.com>
        (greearb@candelatech.com's message of "Wed, 26 Aug 2020 16:20:44
        -0700")
Message-ID: <874knxkdiy.fsf@codeaurora.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

greearb@candelatech.com writes:

> From: Ben Greear <greearb@candelatech.com>
>
> The QCA6390 board I have, model 8291M-PR comes with an ELF board
> file.  To get this to at least somewhat work, I renamed bdwlan.e04
> to 'board.bin' and then added this patch to check for .ELF as
> starting bytes of the board file.  If that is found, use type
> ELF.  After this the driver loads.
>
> Signed-off-by: Ben Greear <greearb@candelatech.com>
> ---
>
> This is on top of recent kvallo ath tree.
>
>  drivers/net/wireless/ath/ath11k/qmi.c | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath11k/qmi.c b/drivers/net/wireless/ath/ath11k/qmi.c
> index 91134510364c..f87f1d1564f4 100644
> --- a/drivers/net/wireless/ath/ath11k/qmi.c
> +++ b/drivers/net/wireless/ath/ath11k/qmi.c
> @@ -1992,6 +1992,7 @@ static int ath11k_qmi_load_bdf_qmi(struct ath11k_base *ab)
>  	struct qmi_txn txn = {};
>  	int ret;
>  	const u8 *temp;
> +	int bdf_type = ATH11K_QMI_BDF_TYPE_BIN;
>  
>  	req = kzalloc(sizeof(*req), GFP_KERNEL);
>  	if (!req)
> @@ -2008,6 +2009,15 @@ static int ath11k_qmi_load_bdf_qmi(struct ath11k_base *ab)
>  	temp = bd.data;
>  	remaining = bd.len;
>  
> +	if (bd.len >= 4) {
> +		char* edata = (char*)(temp);
> +		if (edata[1] == 'E' &&
> +		    edata[2] == 'L' &&
> +		    edata[3] == 'F') {
> +			bdf_type = ATH11K_QMI_BDF_TYPE_ELF;
> +		}
> +	}

Thanks, looks good. Expect that the ELF magic check can be simplified to:

strncmp(edata, ELFMAG, SELFMAG)

But I can send v2, I'll soon send some more QCA6390 patches and I'll
include this to the set.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches