Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1095148pxk; Fri, 18 Sep 2020 03:43:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzK+yAHzYBNmgC7a2+eWp3l4d4HUv7cqrbTJPG9C4wwfks8bwDn3kCjNybw5JUX/QzZ2Maf X-Received: by 2002:a17:906:cc98:: with SMTP id oq24mr34478303ejb.106.1600425835820; Fri, 18 Sep 2020 03:43:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600425835; cv=none; d=google.com; s=arc-20160816; b=YISEvqghcqxpf+ONx0PGelpPGBblxAglhGv47S/o0vUq6cKwrDNgV0RuJKlY0CYYN6 iRJPP5WAiVtEMbjuB/j/PdmK7kFbv5aV6AvYDFgWoQHHqMzws5zdLwGnXH5GGVhUR3ls 5WI3bBSRrhd1EBAImh7RCQbfaV/l1eby9ARFV0XyAlSDIhCZGESM4wtOI5kS60TE8B2L HGvvJJ78ai2i+Y2B3E2V9xfP4VPRqeyPxiY6FZ3g1ThVa3ExFDIYq4CKCNPyal6TKGz9 W69DQwxPTR5lo5+OuVobEhF32CKIy1V8u1y8o4bbPQSD3+tfDEDDUhzjbBojlimlqNnW C4LQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=fS/OffnNQgFJ0pbrrQ4WOukVO0dCw9zwNV/m3DbN2is=; b=uITm9fCFj5uRCvwj4usBn8ACYgOxkokYYqolkeGqwwaGDlH82wuMbDx8bcBu72h7UG v66DlndxlA6gvyl1I9r2VUfs6J1DTtfK42jpR9Ta5GUOBXkoFZhJw+/53SveTKKdz3Oy iplwnfgaXfC8PCrLv0HYtBMKEhENmn2Lp7g+Q5cCYvZcZ1x0TDWTSdOhiurPu1mDi0Zp wJzbj6lo6i779NGeKor8N5eANolvZtrOgX808CBMpuQtkArkXNwkTvzoeRD8Vuh3lkNu zshJfAFT9/glZs9SA0Vdk1uCgBQ2OKaP7p7lIedIsP0fv0qk/hWVsX/jfBxi7pj2tfZt ZZJQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s25si1744748edt.544.2020.09.18.03.43.31; Fri, 18 Sep 2020 03:43:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726118AbgIRKlq (ORCPT + 99 others); Fri, 18 Sep 2020 06:41:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725882AbgIRKlp (ORCPT ); Fri, 18 Sep 2020 06:41:45 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A72FEC06174A for ; Fri, 18 Sep 2020 03:41:45 -0700 (PDT) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94) (envelope-from ) id 1kJDpn-006CW7-Vj; Fri, 18 Sep 2020 12:41:44 +0200 Message-ID: Subject: Re: [PATCH v2 08/22] nl80211: support S1G capabilities From: Johannes Berg To: Thomas Pedersen Cc: linux-wireless Date: Fri, 18 Sep 2020 12:41:43 +0200 In-Reply-To: <20200831205600.21058-9-thomas@adapt-ip.com> References: <20200831205600.21058-1-thomas@adapt-ip.com> <20200831205600.21058-9-thomas@adapt-ip.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Mon, 2020-08-31 at 13:55 -0700, Thomas Pedersen wrote: > > + NL80211_ATTR_S1G_CAPABILITY, > + NL80211_ATTR_S1G_CAPABILITY_MASK, > /* add attributes here, update the policy in nl80211.c */ nit: keep a blank line? > [NL80211_ATTR_HE_6GHZ_CAPABILITY] = > NLA_POLICY_EXACT_LEN(sizeof(struct ieee80211_he_6ghz_capa)), > + [NL80211_ATTR_S1G_CAPABILITY] = { .len = NL80211_S1G_CAPABILITY_LEN }, > + [NL80211_ATTR_S1G_CAPABILITY_MASK] = { > + .len = NL80211_S1G_CAPABILITY_LEN }, Please use the NLA_POLICY_EXACT_LEN() as in the line above, unless this really was meant to be a *minimum* length, which I doubt? johannes