Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <07751701c06d14e39c956369e5b1dd2a066fd69e.camel@sipsolutions.net>
Subject: Re: [PATCH v2 12/22] mac80211: convert S1G beacon to scan results
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Thomas Pedersen <thomas@adapt-ip.com>
Cc:     linux-wireless <linux-wireless@vger.kernel.org>
Date:   Fri, 18 Sep 2020 12:48:42 +0200
In-Reply-To: <20200831205600.21058-13-thomas@adapt-ip.com>
References: <20200831205600.21058-1-thomas@adapt-ip.com>
         <20200831205600.21058-13-thomas@adapt-ip.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 2020-08-31 at 13:55 -0700, Thomas Pedersen wrote:

>  
> +	if (!elems->parse_error && elems->s1g_capab)
> +		bss->s1g = true;

It seems odd to set this only if it's in error - why not always set it
if the band is right?

In fact, why set it at all, since you always know the band?

> +		case WLAN_EID_S1G_CAPABILITIES:
> +			if (elen == 15)
> +				elems->s1g_capab = (void *)pos;
> +			else
> +				elem_parse_failed = true;
> +			break;
> +		case WLAN_EID_S1G_OPERATION:
> +			if (elen == 6)
> +				elems->s1g_oper = (void *)pos;
> +			else
> +				elem_parse_failed = true;
> +			break;
> +		case WLAN_EID_S1G_SHORT_BCN_INTERVAL:
> +			if (elen == 2)
> +				elems->s1g_tsbtt = (void *)pos;
> +			else
> +				elem_parse_failed = true;
> +			break;

Seems like you ought to have some structs/sizeof or defines for the
sizes?

johannes