Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <5025b542741e18d0f329b5a1f5d110fd6a1eeae0.camel@sipsolutions.net>
Subject: Re: [PATCH v2 13/22] cfg80211: handle Association Response from S1G
 STA
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Thomas Pedersen <thomas@adapt-ip.com>
Cc:     linux-wireless <linux-wireless@vger.kernel.org>
Date:   Fri, 18 Sep 2020 12:50:22 +0200
In-Reply-To: <20200831205600.21058-14-thomas@adapt-ip.com>
References: <20200831205600.21058-1-thomas@adapt-ip.com>
         <20200831205600.21058-14-thomas@adapt-ip.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 2020-08-31 at 13:55 -0700, Thomas Pedersen wrote:
> 
> +	/* Detect whether this was an S1G Association Response and adjust IE
> +	 * location accordingly.
> +	 */
> +	rcu_read_lock();
> +	ies = rcu_dereference(bss->ies);
> +	if (WARN_ON(!ies)) {
> +		rcu_read_unlock();
> +		return;
> +	}
> +	s1g = cfg80211_find_ie(WLAN_EID_S1G_CAPABILITIES, ies->data, ies->len);
> +	if (s1g) {
> +		cr.resp_ie = (u8 *)&mgmt->u.s1g_assoc_resp.variable;
> +		cr.resp_ie_len =
> +			len - offsetof(struct ieee80211_mgmt,
> +				       u.s1g_assoc_resp.variable);
> +	}
> +	rcu_read_unlock();

That ... is rather strange?

Why not check bss->channel->band?

johannes