Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <d922fa0215d8617c92948e1ddee5d23f77610723.camel@sipsolutions.net>
Subject: Re: [PATCH v2 15/22] mac80211: don't calculate duration for S1G
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Thomas Pedersen <thomas@adapt-ip.com>
Cc:     linux-wireless <linux-wireless@vger.kernel.org>
Date:   Fri, 18 Sep 2020 12:52:47 +0200
In-Reply-To: <20200831205600.21058-16-thomas@adapt-ip.com>
References: <20200831205600.21058-1-thomas@adapt-ip.com>
         <20200831205600.21058-16-thomas@adapt-ip.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 2020-08-31 at 13:55 -0700, Thomas Pedersen wrote:
> For now just skip the duration calculation for frames
> transmitted on the S1G band and avoid a warning.
> 
> Signed-off-by: Thomas Pedersen <thomas@adapt-ip.com>
> ---
>  net/mac80211/tx.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
> index d2136007e2eb..bef19616c5f0 100644
> --- a/net/mac80211/tx.c
> +++ b/net/mac80211/tx.c
> @@ -82,6 +82,10 @@ static __le16 ieee80211_duration(struct ieee80211_tx_data *tx,
>  
>  	erp = txrate->flags & IEEE80211_RATE_ERP_G;
>  
> +	/* TODO */
> +	if (sband->band == NL80211_BAND_S1GHZ)
> +		return 0;


I'm not even sure I'd leave a TODO there ... just say

	/* device is expected to do this */

or so?

johannes