Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1102434pxk; Fri, 18 Sep 2020 03:58:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxaCSbzebAAetH7GT+KeekyBkWKqr+9/TSYVxbFKkAAPW7JV06GUZsGwEQ4hAINg4+n69E/ X-Received: by 2002:a17:906:455:: with SMTP id e21mr36972510eja.170.1600426733035; Fri, 18 Sep 2020 03:58:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600426733; cv=none; d=google.com; s=arc-20160816; b=DBXIKhcE9VziNQ2s8CkytLYpOxw1EAhNxU0cGRAoNEUMiUa0wGpb8VO9/hyT0ndZRk uMHGWMbLm0vojDSwBHMhClqzflnBjgB0rnWuCUqDM9dZt4BFmuH1ipmuRtAu+D+pSP7S FrEUO2ulmNDpS4q4wNo4y7Ior3Zr4YJNEQbCix0eHH8+9i5HpPf1N8ECs2Y37EmGRfle 7gA/WVR/L25w8OpsKGLyMVGGsLF/ApJ1G5KyaiF+Klc8+uzFwDEJI7NSXPAiX268XFRy c74CMeKOTUraACYpejtSYTQnKVfpK4EB4VKoxr50TGnMe6wljBFmXL+igTVlKDRzfKS4 EYjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=s+SVYlNkP1ynwUA9MfJeyfsJl9ZL16ZtTcsV00jW/KY=; b=sCkwectFdFCEqnnjwaBBUQ/cEm76Hb/KlUGxs0AOO+NYvQC43fC3obFzLXTMOlORnt 2symyEoo6fpwIdXhDDpyA2s0LeASlDHyCEPnqkJVRvhvwzSNSKVuknR+niZ9g0E9RecD H77ZOO6sPOl5RwERTFxGvvaMB+F1rTt6S0RXoMHZfmL+tvELD5j1hCMVyI2pdce88x1a AOaIjKitVX2fcvQMSqHEpB6ZDgaca2bCSCiRpua9srsZhOPcW9ff4pnM8wpTx4vowi/P Kfsx3WElxuKORaxveHm605UzdnwFeCTEv8qrJM4TGPldbLjut4vN5H0KVcG7fGEbMP/D tJEg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a3si1705761ejt.659.2020.09.18.03.58.27; Fri, 18 Sep 2020 03:58:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726239AbgIRK4I (ORCPT + 99 others); Fri, 18 Sep 2020 06:56:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725941AbgIRK4I (ORCPT ); Fri, 18 Sep 2020 06:56:08 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28AD7C06174A for ; Fri, 18 Sep 2020 03:56:08 -0700 (PDT) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94) (envelope-from ) id 1kJE3i-006Cxv-Fu; Fri, 18 Sep 2020 12:56:06 +0200 Message-ID: <8b7f1ab8a15a06a23b7db2fb120e3144c482d7b9.camel@sipsolutions.net> Subject: Re: [PATCH v3 04/22] nl80211: correctly validate S1G beacon head From: Johannes Berg To: Thomas Pedersen Cc: linux-wireless Date: Fri, 18 Sep 2020 12:56:05 +0200 In-Reply-To: <20200908190323.15814-5-thomas@adapt-ip.com> References: <20200908190323.15814-1-thomas@adapt-ip.com> <20200908190323.15814-5-thomas@adapt-ip.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, 2020-09-08 at 12:03 -0700, Thomas Pedersen wrote: > The S1G beacon has a different header size than regular > beacons, so adjust the beacon head validator. I've applied this already and will keep it, but you later add short beacons - don't they need further adjustments here too? johannes