Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1109493pxk; Fri, 18 Sep 2020 04:09:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzl1FI80lr5GZWcrNlyI/zYwrbC6sybxvjU/TqmEDN06qo48vZqLmzQc5No3+YBdJQjK//m X-Received: by 2002:a17:906:6993:: with SMTP id i19mr34018525ejr.26.1600427354619; Fri, 18 Sep 2020 04:09:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600427354; cv=none; d=google.com; s=arc-20160816; b=WUlqRupooMzLBo6XwoBg4EUuK64BdDYtacVFmYq/Atu+dxYZ9YeC3WBVZxV7M4xwXc 38ZavsCPP6V4QN6JMHMXleMn48UA4Rc16Qt/j1eDoU+h9r8pvbuvOAqZ1sRaaiF11ON3 q/BsVznI+SioY+SaGKSH7k/u+OldY6UqDk7AFhvHnXRGBza/xGLoFewVsnRRhKJdyLK0 Kf9sv2BKgAnJlA7VD/2E/eAWx1J2NuQDUkgz/jrzJYBDxZbsfp1WFdEhR5xIJuBsYDTM dhQg0f6YbjwcmJjuZg/Lop6g5Z+z7PG0gizEl/tRNbWtD+C78GfkhN54h4gawqkR4sv+ 0mIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=DuDlPEVNcAw1rVmAIN9DROjVCN+NzrDrGbm7es4WDQs=; b=HLYB7H06Rn1Sp15Y8MOhJe/cdpLsE90Q83sHd9j1mOtt5db+mqZ0H3T9WsUjdMBcNQ K0ZKCoVWLBq11KJOxR9FVmSuKhIGiVlJOvl+t3LcF+gKn584/vnDqf7rayi20fqs8IX5 cZvJqrJLC5nL5kSiSrUcZa7evp6hDiSHKNY+45mtcW8/CvmZFSDDtIDBLR+igLYJUGx6 HYtlIDcI8+BwT7P38URVMJKlTq1Tt1ZXvpZn0cJAHdzcMK52r9VXONbs55wps2VujOXg m6nurYGW7OYx1EVPHtfd8oLx+j5bEeAGkUQCfc7D+uis5FmX71hlltd756kpU8fOQVp/ RzPA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i18si1858404edv.542.2020.09.18.04.08.50; Fri, 18 Sep 2020 04:09:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726205AbgIRLIc (ORCPT + 99 others); Fri, 18 Sep 2020 07:08:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725941AbgIRLIc (ORCPT ); Fri, 18 Sep 2020 07:08:32 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 080A5C06174A for ; Fri, 18 Sep 2020 04:08:31 -0700 (PDT) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94) (envelope-from ) id 1kJEFi-006DG9-75; Fri, 18 Sep 2020 13:08:30 +0200 Message-ID: <35408120e5133a4a170922af6bc33e21198c693c.camel@sipsolutions.net> Subject: Re: mac80211: fix xmit callback when hwencap enable From: Johannes Berg To: P Praneesh Cc: linux-wireless@vger.kernel.org Date: Fri, 18 Sep 2020 13:08:29 +0200 In-Reply-To: <1597219503-18295-1-git-send-email-ppranees@codeaurora.org> References: <1597219503-18295-1-git-send-email-ppranees@codeaurora.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Wed, 2020-08-12 at 13:35 +0530, P Praneesh wrote: > Since transmit control port uses same callback for both > (ieee80211_subif_start_xmit) ethernet mode and native > wifi mode, which causes authentication issue (M2 Handshake failure) > in ethernet mode with encryption(psk2+ccmp). > This will also be an issue for hw/fw which doesn't support per > packet tx/rx encap/decap. > > Added hardware encap check to filter out ethernet mode > packets to follow ieee80211_subif_start_xmit_8023 path. This has some major conflicts with Felix's work, please check if that is already fixing the issue. I think it is. johannes