Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <a953c6d139ce7d30b0830574ead2d130817fa12c.camel@sipsolutions.net>
Subject: Re: [PATCH v3 04/22] nl80211: correctly validate S1G beacon head
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Thomas Pedersen <thomas@adapt-ip.com>
Cc:     linux-wireless <linux-wireless@vger.kernel.org>
Date:   Fri, 18 Sep 2020 19:47:49 +0200
In-Reply-To: <97924cf65e6806fd896ada049f3d46ea@adapt-ip.com>
References: <20200908190323.15814-1-thomas@adapt-ip.com>
         <20200908190323.15814-5-thomas@adapt-ip.com>
         <8b7f1ab8a15a06a23b7db2fb120e3144c482d7b9.camel@sipsolutions.net>
         <97924cf65e6806fd896ada049f3d46ea@adapt-ip.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 2020-09-18 at 10:45 -0700, Thomas Pedersen wrote:
> On 2020-09-18 03:56, Johannes Berg wrote:
> > On Tue, 2020-09-08 at 12:03 -0700, Thomas Pedersen wrote:
> > > The S1G beacon has a different header size than regular
> > > beacons, so adjust the beacon head validator.
> > 
> > I've applied this already and will keep it, but you later add short
> > beacons - don't they need further adjustments here too?
> 
> Yes, but I was planning on doing that in the (yet to be submitted) "add 
> S1G short beacon support" patch.

OK, fair enough, was just wondering :)

johannes