Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: Larry Finger <larry.finger@gmail.com>
Subject: Re: [PATCH -next 5/9] rtlwifi: rtl8821ae: fix comparison to bool
 warning in phy.c
To:     Zheng Bin <zhengbin13@huawei.com>, pkshih@realtek.com,
        kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     yi.zhang@huawei.com
References: <20200918102505.16036-1-zhengbin13@huawei.com>
 <20200918102505.16036-6-zhengbin13@huawei.com>
From:   Larry Finger <Larry.Finger@lwfinger.net>
Message-ID: <762b547f-1c5e-15cb-ce1f-b94caaebbbe5@lwfinger.net>
Date:   Fri, 18 Sep 2020 15:48:17 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20200918102505.16036-6-zhengbin13@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/18/20 5:25 AM, Zheng Bin wrote:
> Fixes coccicheck warning:
> 
> drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c:1816:5-13: WARNING: Comparison to bool
> drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c:1825:5-13: WARNING: Comparison to bool
> drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c:1839:5-13: WARNING: Comparison to bool
> 
> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
> ---
>   drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)

Acked-by: Larry Finger <Larry.Finger@lwfinger.net>

Larry

> 
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c
> index 7832fae3d00f..38669b4d6190 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c
> @@ -1813,7 +1813,7 @@ static bool _rtl8821ae_phy_bb8821a_config_parafile(struct ieee80211_hw *hw)
> 
>   	rtstatus = _rtl8821ae_phy_config_bb_with_headerfile(hw,
>   						       BASEBAND_CONFIG_PHY_REG);
> -	if (rtstatus != true) {
> +	if (!rtstatus) {
>   		pr_err("Write BB Reg Fail!!\n");
>   		return false;
>   	}
> @@ -1822,7 +1822,7 @@ static bool _rtl8821ae_phy_bb8821a_config_parafile(struct ieee80211_hw *hw)
>   		rtstatus = _rtl8821ae_phy_config_bb_with_pgheaderfile(hw,
>   						    BASEBAND_CONFIG_PHY_REG);
>   	}
> -	if (rtstatus != true) {
> +	if (!rtstatus) {
>   		pr_err("BB_PG Reg Fail!!\n");
>   		return false;
>   	}
> @@ -1836,7 +1836,7 @@ static bool _rtl8821ae_phy_bb8821a_config_parafile(struct ieee80211_hw *hw)
>   	rtstatus = _rtl8821ae_phy_config_bb_with_headerfile(hw,
>   						BASEBAND_CONFIG_AGC_TAB);
> 
> -	if (rtstatus != true) {
> +	if (!rtstatus) {
>   		pr_err("AGC Table Fail\n");
>   		return false;
>   	}
> --
> 2.26.0.106.g9fadedd
>