Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp2870615pxk; Sun, 20 Sep 2020 21:35:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzG3g5tskxa2SOYFcgFoCJvIxqIaMJmiARmjYFJEhXqufBjWprtC56wQVJyuPrOBSUjD8D9 X-Received: by 2002:a17:906:33d8:: with SMTP id w24mr47023467eja.224.1600662899799; Sun, 20 Sep 2020 21:34:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600662899; cv=none; d=google.com; s=arc-20160816; b=BBPABqbhRi5IHTDMTMnMELKmkhQpvP0GPFV/NCxO+vbAUJmheU4s9CXLOMDy/IY0hc hS8EQdIZPZVZ6skiUGIDvo2iZAzI98acd2aXSI881dyCzQsjy6kahBthedJ/alhOWDG9 nBVTrwyuc1VX37olntDSy9BO6NTq5qmpWoEd+BYP0qzsDxUOmwm+Ng4uVSuRWJOe4c6l 2fxDD8I09+GjUq3AsgGmmlaghqw+d23n3CeW7++UYSyt+dMeo6cV/CVDlvdRJRF9Cn1G of/ncIpGwasOkmGy4nmdENKch+igP5+aQ4TBMCIDVRrA8b18fmxeJhF6Jqod5IA1efqi cgdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:message-id:user-agent :references:in-reply-to:subject:cc:to:from:date:mime-version; bh=sTSlWomMcy3KXPgG0gA+WBLgDy4UBimX5dBDmY3DTE0=; b=aVJG6bgkRKJlR/AiIOXr7P8ed0SdmivNIt5Tf7DtTN5uWwfqgllTTXxzLrisCfG2vU t5wA6wdL5e9Ws4zOkCGHL4/dfYqN/44ZWmKZsX4u5ivMGuKaaYDqcWFE/eBUS/XHbWIA rsENGRCcxp3Vnrra7H9dGv65UzncojNWU5tLVlApGttlnPZxg272gcOLLF0EVALixpqY la9eFU6yRMzfGafHEKv/mxvmmKvond+3dTBVxdRhnq9fvyYubaJR4CxuBF7sHePTmrrw GhaZO3MNI8dVpfKU2f94yByDPQ9RGhZ0Lw9+1a9LiSbDGfy5oziCSD+WAyokwVhTPl6X 8bQg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jp7si7387262ejb.742.2020.09.20.21.34.23; Sun, 20 Sep 2020 21:34:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726196AbgIUEeN (ORCPT + 99 others); Mon, 21 Sep 2020 00:34:13 -0400 Received: from mail.adapt-ip.com ([173.164.178.19]:45582 "EHLO web.adapt-ip.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726011AbgIUEeN (ORCPT ); Mon, 21 Sep 2020 00:34:13 -0400 Received: from localhost (localhost [127.0.0.1]) by web.adapt-ip.com (Postfix) with ESMTP id CFF804F9809; Mon, 21 Sep 2020 04:34:12 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at web.adapt-ip.com Received: from web.adapt-ip.com ([127.0.0.1]) by localhost (web.adapt-ip.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id mGmi6slOP08h; Mon, 21 Sep 2020 04:34:10 +0000 (UTC) Received: from mail.ibsgaard.io (c-73-223-60-234.hsd1.ca.comcast.net [73.223.60.234]) (Authenticated sender: thomas@adapt-ip.com) by web.adapt-ip.com (Postfix) with ESMTPSA id 2E7414F2252; Mon, 21 Sep 2020 04:34:10 +0000 (UTC) MIME-Version: 1.0 Date: Sun, 20 Sep 2020 21:34:09 -0700 From: Thomas Pedersen To: Johannes Berg Cc: linux-wireless Subject: Re: [PATCH v2 08/22] nl80211: support S1G capabilities In-Reply-To: <56d639c4f045b205ab311ab80c0ff5a18d4af7fb.camel@sipsolutions.net> References: <20200831205600.21058-1-thomas@adapt-ip.com> <20200831205600.21058-9-thomas@adapt-ip.com> <56d639c4f045b205ab311ab80c0ff5a18d4af7fb.camel@sipsolutions.net> User-Agent: Roundcube Webmail/1.4.7 Message-ID: <19a455508af9f394e9c6ad1defff86bf@adapt-ip.com> X-Sender: thomas@adapt-ip.com Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2020-09-18 03:47, Johannes Berg wrote: > On Mon, 2020-08-31 at 13:55 -0700, Thomas Pedersen wrote: >> @@ -3046,6 +3054,7 @@ enum nl80211_attrs { >> #define NL80211_TKIP_DATA_OFFSET_RX_MIC_KEY 24 >> #define NL80211_HT_CAPABILITY_LEN 26 >> #define NL80211_VHT_CAPABILITY_LEN 12 >> +#define NL80211_S1G_CAPABILITY_LEN 15 > > Maybe that would make more sense in ieee80211.h? Renamed, of course? Makes sense, thanks I'll take care of that and the other comments in this patch. -- thomas