Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
Date:   Sun, 20 Sep 2020 22:56:33 -0700
From:   Thomas Pedersen <thomas@adapt-ip.com>
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2 14/22] mac80211: encode listen interval for S1G
In-Reply-To: <05ad5f4f7623e6e072eebf7b87320fa7385fac35.camel@sipsolutions.net>
References: <20200831205600.21058-1-thomas@adapt-ip.com>
 <20200831205600.21058-15-thomas@adapt-ip.com>
 <05ad5f4f7623e6e072eebf7b87320fa7385fac35.camel@sipsolutions.net>
User-Agent: Roundcube Webmail/1.4.7
Message-ID: <22637776046b8defc4cf98f4b507f769@adapt-ip.com>
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2020-09-18 03:51, Johannes Berg wrote:
> On Mon, 2020-08-31 at 13:55 -0700, Thomas Pedersen wrote:
> 
>> +static const int listen_int_usf[] = { 1, 10, 1000, 10000 };
> 
> That should probably be in some C file?
> 
> OTOH ... maybe it's small enough to duplicate everywhere? could make it
> u16 at least :)
> 
>> +__le16 ieee80211_encode_usf(int listen_interval)
>> +{
>> +	u16 ui, usf = 0;
>> +
>> +	/* find greatest USF */
>> +	while (usf < IEEE80211_MAX_USF) {
>> +		if (listen_interval % listen_int_usf[usf + 1])
>> +			break;
>> +		usf += 1;
>> +	}
>> +	ui = listen_interval / listen_int_usf[usf];
> 
> But you really only need it here in one place anyway.

OK better to keep it private to that file then.

-- 
thomas