Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp2923011pxk; Sun, 20 Sep 2020 23:54:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwVPFJQmGCHEXCfzL/UzCTC0eUK3xNIFRiEbrbSp2LBPgbyLpj8BYhsqpyoTVzR6YqMiP9R X-Received: by 2002:aa7:c154:: with SMTP id r20mr51597848edp.337.1600671292855; Sun, 20 Sep 2020 23:54:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600671292; cv=none; d=google.com; s=arc-20160816; b=p6IQuMlgjTR0j4Z23rz1XC3wkECxY45QAkNfLOP1Z+3/dcHfIly2zbhB35e+MloL3r bOtMNGlay9glzbGzt3sAmeaagmAJcXRc+kTJbMx3IxEIBfuA1IdD3PT63J+M1IZSBAvU 3h6xR5NtH85EXMLfK6eL+IDZdiukfwEicF+kGx2WjVFEK4OKEvYnl4iE2fKi1wpQdiGO ltSMMPxUziZJIHu36ebaiIvnLymWQJNfiHBKXRJg4RSBrJ/N2AFwRHtNa4jyJQwQjSPp U4nGitZQI/BgetIXCxWI0FEzi799W6UVAntnfr+pPrxtLxqsG75bIS1lv92UE5N30e6f WlNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=+KKM0ZRDou2qoiIScK9kkTCXA34bLxYYNAbK/84ckPA=; b=NNfw6YoX5ADqxhb0sRQAin+ybynFw1IZfJ+YGEtaiLRYwCXg6g7yO0oKasajLnZgf0 cDalN3WlEho4MsnVrbAmM66MxBvVKb32Yfr9qmVzCjwbyP30wKhIbfob9ns0RIRoVBsd yAQ7CMxGjTnqp3exqC7Dpna/Em8H+nyiYiORwTDMJQH03i9h4XH4ZyT8QzE2Wqihqahg BjsWQRkpgl5IUkc2kY3m+NtrZytJM3kB/QMjrBdaBb8bFWzJoSg/pCRQEXaOUlq44wiO onxDlWg0k6j0Txk2ramus5hcus8T/gFMY2itfTqx6AYOid9B5of7f72S2vlC36e4zQZ0 Wllg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y4si7497076edt.161.2020.09.20.23.54.20; Sun, 20 Sep 2020 23:54:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726211AbgIUGyI (ORCPT + 99 others); Mon, 21 Sep 2020 02:54:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726011AbgIUGyI (ORCPT ); Mon, 21 Sep 2020 02:54:08 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6BB11C061755 for ; Sun, 20 Sep 2020 23:54:08 -0700 (PDT) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94) (envelope-from ) id 1kKFiA-00849u-KG; Mon, 21 Sep 2020 08:54:06 +0200 Message-ID: <215a340b904177c779b7cdd2ecd291d7a0170265.camel@sipsolutions.net> Subject: Re: [PATCH v2 11/22] cfg80211: parse S1G Operation element for BSS channel From: Johannes Berg To: Thomas Pedersen Cc: linux-wireless Date: Mon, 21 Sep 2020 08:54:05 +0200 In-Reply-To: References: <20200831205600.21058-1-thomas@adapt-ip.com> <20200831205600.21058-12-thomas@adapt-ip.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Sun, 2020-09-20 at 22:12 -0700, Thomas Pedersen wrote: > On 2020-09-18 03:45, Johannes Berg wrote: > > On Mon, 2020-08-31 at 13:55 -0700, Thomas Pedersen wrote: > > > Extract the BSS primary channel from the S1G Operation > > > element. > > > > Out of curiosity, do you even need to? > > > > I mean ... you know what channel you received it on, surely? > > Consider the case where the BSS is operating @ 2Mhz, but primary is one > of > the 1Mhz channels. The hardware (or driver) may not be able to tell you > exactly which primary channel (upper or lower) the packet came in on. Ah, OK, makes sense. Somehow based on a comment somewhere else I thought you were saying that the channels are basically all unique in their (center frequency, bandwidth) tuple, and was assuming you'd actually have to scan them that way. johannes