Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <21104fe9de252ecc993deb1a65a5b182f348dec8.camel@sipsolutions.net>
Subject: Re: [PATCH v2 15/22] mac80211: don't calculate duration for S1G
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Thomas Pedersen <thomas@adapt-ip.com>
Cc:     linux-wireless <linux-wireless@vger.kernel.org>
Date:   Mon, 21 Sep 2020 08:51:19 +0200
In-Reply-To: <b9d1a036f2b10a640a3e88fd23fb8ef3@adapt-ip.com>
References: <20200831205600.21058-1-thomas@adapt-ip.com>
         <20200831205600.21058-16-thomas@adapt-ip.com>
         <d922fa0215d8617c92948e1ddee5d23f77610723.camel@sipsolutions.net>
         <b9d1a036f2b10a640a3e88fd23fb8ef3@adapt-ip.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sun, 2020-09-20 at 23:03 -0700, Thomas Pedersen wrote:
> 
> > I'm not even sure I'd leave a TODO there ... just say
> > 
> > 	/* device is expected to do this */
> 
> Eventually it would be nice if mac80211 could calculate duration for 
> S1G? Do you know why it doesn't for HT/VHT?

I'm not sure it matters. It almost doesn't even matter for legacy
(CCK/OFDM) because devices practically always do it anyway?

And for HT/VHT it's just quite a bit more complicated, so we never
bothered, since it wasn't necessary.

It couldn't even really be done since there are A-MPDUs and other things
happening at a lower layer.

johannes