Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] wireless: ath9k: hif_usb: fix race condition between
 usb_get_urb() and usb_kill_anchored_urbs()
To:     Kalle Valo <kvalo@codeaurora.org>
Cc:     davem@davemloft.net, kuba@kernel.org, gregkh@linuxfoundation.org,
        linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
        ath9k-devel@qca.qualcomm.com, syzkaller-bugs@googlegroups.com,
        syzbot+89bd486af9427a9fc605@syzkaller.appspotmail.com
References: <20200911071427.32354-1-brookebasile@gmail.com>
 <20200921130559.005D8C43382@smtp.codeaurora.org>
From:   Brooke Basile <brookebasile@gmail.com>
Message-ID: <22bfd12a-c7ea-f03f-5d44-f94646b083f3@gmail.com>
Date:   Mon, 21 Sep 2020 19:04:38 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20200921130559.005D8C43382@smtp.codeaurora.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/21/20 9:05 AM, Kalle Valo wrote:
> Brooke Basile <brookebasile@gmail.com> wrote:
> 
>> Calls to usb_kill_anchored_urbs() after usb_kill_urb() on multiprocessor
>> systems create a race condition in which usb_kill_anchored_urbs() deallocates
>> the URB before the completer callback is called in usb_kill_urb(), resulting
>> in a use-after-free.
>> To fix this, add proper lock protection to usb_kill_urb() calls that can
>> possibly run concurrently with usb_kill_anchored_urbs().
>>
>> Reported-by: syzbot+89bd486af9427a9fc605@syzkaller.appspotmail.com
>> Link: https://syzkaller.appspot.com/bug?id=cabffad18eb74197f84871802fd2c5117b61febf
>> Signed-off-by: Brooke Basile <brookebasile@gmail.com>
>> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
> 
> Patch applied to ath-next branch of ath.git, thanks.
> 
> 03fb92a432ea ath9k: hif_usb: fix race condition between usb_get_urb() and usb_kill_anchored_urbs()
> 

Thank you! :)

Best,
Brooke Basile