Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <bfe45686ca8d8b5db2b27e33859bea7450f7b920.1601133687.git.lorenzo@kernel.org>
 <a4e15f9f-a296-f862-6216-ed3b40423aa7@nbd.name>
In-Reply-To: <a4e15f9f-a296-f862-6216-ed3b40423aa7@nbd.name>
From:   Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Date:   Sun, 27 Sep 2020 18:27:06 +0200
Message-ID: <CAJ0CqmU7TwUuuSJLVMM-ymgRigM-YuNDBrSOgzHi1R-wcFjr=g@mail.gmail.com>
Subject: Re: [PATCH] mt76: mt7615: enable beacon filtering by default for
 offload fw
To:     Felix Fietkau <nbd@nbd.name>
Cc:     Lorenzo Bianconi <lorenzo@kernel.org>,
        linux-wireless <linux-wireless@vger.kernel.org>,
        Sean Wang <sean.wang@mediatek.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

>
> On 2020-09-26 17:22, Lorenzo Bianconi wrote:
> > In order to reduce cpu cycles, enable hw beacon filter by default if the
> > device is running offload fw
> >
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> The beacon filtering part and runtime pm needs to take into account that
> there could be more than one vif and we might be running an AP as well.
>
> - Felix
>

Do you mean we should run mt7615_mcu_set_bss_pm() for other vif types, e.g. AP?
IIUC the fw can manage the rx beacon offload even for other modes.

@Sean: do we need to send any other message to mcu for rx beacon
offload for AP mode? Can the fw properly manage it?

Regards,
Lorenzo