Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3596062pxk; Tue, 29 Sep 2020 00:44:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx8OKdwoQcesSLEZ2vpAXv8PXAkjJGODvrzDr4PfTltZlUqOpybVLPvhx0lm/8JCnyeuHGq X-Received: by 2002:aa7:c387:: with SMTP id k7mr1789920edq.242.1601365444220; Tue, 29 Sep 2020 00:44:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601365444; cv=none; d=google.com; s=arc-20160816; b=qs4UY87j62zk66R4KvGW8J/rZdmEcy0mnqUJGKtrEaUAf15WkHcWe9YwL25HCmeYBn y9scd77Z/Ut7xmR8aXDnlkwAKUzJUAWvrkO407NBDxrPmALYkNBMIzqwA9j0LLP8qJyz DHjtnW6wZD0CIIkkd7/vshI7RjG6vdJFSAI/B5pKIL71QD7f0sPdOrkKZjdMD7JMlpkj MYR7BAHHCdm7XGby7Hg3Fwgzshz9Hf0MbGXuJIsYj7n3++4SoBGFNFDK3+hhXz31jNLA +AT8NYvVeN1IO7xfIbebO/WUTEeg714Fu1wQDwwSEzRS/YHGctkqId3OglJujTM9pwdw kzYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dmarc-filter:sender :dkim-signature; bh=xnb87Cfve1xF0bCoXPYTCokfdr8oqsQE0Dv24ZOgSVo=; b=fkFLxkUOom0AzkQIYf8RQllA2b3snykG6KB0s+W7l1THnrFI1A0ny/hXwL5j/0Xz2a MmGIhVzZLKRrvYf6XnkOVR8ufByFCtDGygtWZcKkhAyb2y8wkPXopoj0fKgKEQ0gZtIM 4fnqqGDRFnH4mOhogf6MzftM3vZ6A9Ydbz9n0X2GLW7UphiSbj4dDlNPjpCk/9n5LzM6 vuw959aX9EHEp5NiLyyM0tgQdqR4nSPUAHNmw51K8UNZgrfvGdrzII72/SfUcfUJtlqD 58P0KYwBLgGDxe5cNLWUHGyuTVnCjx3+Eib01b1dREB14zc5niqc8bHY/Ycf7m1qQ6TV 3PmQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=Y7JieTaV; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x23si2123758ejb.588.2020.09.29.00.43.35; Tue, 29 Sep 2020 00:44:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=Y7JieTaV; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725536AbgI2Hku (ORCPT + 99 others); Tue, 29 Sep 2020 03:40:50 -0400 Received: from z5.mailgun.us ([104.130.96.5]:15470 "EHLO z5.mailgun.us" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725355AbgI2Hkt (ORCPT ); Tue, 29 Sep 2020 03:40:49 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1601365249; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=xnb87Cfve1xF0bCoXPYTCokfdr8oqsQE0Dv24ZOgSVo=; b=Y7JieTaVpFpgvAwn2NL8uLPDJGzG22xqe+bxpeTfU79/dIY43wFGung5KU6FqiwuNU1cxiNp 2d/EkXo2StXzwmPUyAz6hNwvOa1qv5GmQLpd4JJVNH9pf4t/VsPdGq+8BN+cUpwt8pGtuIpu j8pROzY/x2fLb5dWfZoxRoIXWOU= X-Mailgun-Sending-Ip: 104.130.96.5 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n03.prod.us-west-2.postgun.com with SMTP id 5f72e4ff0f8c6dd7d2825739 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 29 Sep 2020 07:40:47 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 6ED86C433CB; Tue, 29 Sep 2020 07:40:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00,SPF_FAIL autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id CCB7AC433CA; Tue, 29 Sep 2020 07:40:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org CCB7AC433CA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Johannes Berg Cc: Venkateswara Naralasetty , ath11k@lists.infradead.org, linux-wireless@vger.kernel.org Subject: Re: [PATCHv2 1/2] nl80211: vendor-cmd: qca: add command for ap power save References: <1598257589-19091-1-git-send-email-vnaralas@codeaurora.org> <4b4a0d79a243c1c3b8044730da0493c96ba294bf.camel@sipsolutions.net> Date: Tue, 29 Sep 2020 10:40:42 +0300 In-Reply-To: <4b4a0d79a243c1c3b8044730da0493c96ba294bf.camel@sipsolutions.net> (Johannes Berg's message of "Mon, 28 Sep 2020 13:24:22 +0200") Message-ID: <871rilf2th.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Johannes Berg writes: > On Mon, 2020-08-24 at 13:56 +0530, Venkateswara Naralasetty wrote: >> AP power save feature is to save power in AP mode, where AP goes >> to power save mode when no stations associate to it and comes out >> of power save when any station associate to AP. > > Why do you think this requires a vendor command? I mean, that seems like > fairly reasonable - even by default - behaviour? I have not studied the details, but doesn't AP power save break normal functionality? For example, I would guess probe requests from clients would be lost. So there's a major drawback when enabling this, right? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches