Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: Larry Finger <larry.finger@gmail.com>
Subject: Re: Error in driver for RTL8821CE
To:     Cristian Llanos <cristian.llanos@gmail.com>,
        linux-wireless@vger.kernel.org
References: <CANBg+yz2az1o9u7RDD6jwXCs=08u7izbmUOnkKJc2tnOQQCdog@mail.gmail.com>
From:   Larry Finger <Larry.Finger@lwfinger.net>
Message-ID: <97d78a81-b4fb-be83-5cb9-fa69575758c9@lwfinger.net>
Date:   Mon, 5 Oct 2020 15:46:13 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <CANBg+yz2az1o9u7RDD6jwXCs=08u7izbmUOnkKJc2tnOQQCdog@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 10/5/20 2:46 PM, Cristian Llanos wrote:
> Hi, my name is Cristian, I'm writing from Chile
> 
> I'm trying to install the driver for my RTL8821CE card. I'm following
> the instructions from the repo https://github.com/lwfinger/rtw88 (I
> took the email from there) but when I try to run the "make" command, I
> get the following error:
> 
> /home/cristian/Downloads/realtek_drivers/rtw88/main.c: In function
> ‘rtw_core_init’:
> /home/cristian/Downloads/realtek_drivers/rtw88/main.c:1623:2: error:
> implicit declaration of function ‘tasklet_setup’
> [-Werror=implicit-function-declaration]
>   1623 |  tasklet_setup(&rtwdev->tx_tasklet, rtw_tx_tasklet);
> 
> 
> this is the output from "sudo lshw -C network" and the full log of the error.
> 
> ===========
> 
> 
> cristian@cristian-HP-240-G7-Notebook-PC:~/Downloads/realtek_drivers/rtw88$
> sudo lshw -C network
>    *-network
>         description: Ethernet interface
>         product: RTL8111/8168/8411 PCI Express Gigabit Ethernet Controller
>         vendor: Realtek Semiconductor Co., Ltd.
>         physical id: 0
>         bus info: pci@0000:01:00.0
>         logical name: enp1s0
>         version: 15
>         serial: 84:2a:fd:5a:7f:6e
>         capacity: 1Gbit/s
>         width: 64 bits
>         clock: 33MHz
>         capabilities: pm msi pciexpress msix bus_master cap_list
> ethernet physical tp mii 10bt 10bt-fd 100bt 100bt-fd 1000bt-fd
> autonegotiation
>         configuration: autonegotiation=on broadcast=yes driver=r8169
> firmware=rtl8168h-2_0.0.2 02/26/15 latency=0 link=no multicast=yes
> port=MII
>         resources: irq:19 ioport:4000(size=256)
> memory:80504000-80504fff memory:80500000-80503fff
>    *-network UNCLAIMED
>         description: Network controller
>         product: RTL8821CE 802.11ac PCIe Wireless Network Adapter
>         vendor: Realtek Semiconductor Co., Ltd.
>         physical id: 0
>         bus info: pci@0000:02:00.0
>         version: 00
>         width: 64 bits
>         clock: 33MHz
>         capabilities: pm msi pciexpress cap_list
>         configuration: latency=0
>         resources: ioport:3000(size=256) memory:80400000-8040ffff
> cristian@cristian-HP-240-G7-Notebook-PC:~/Downloads/realtek_drivers/rtw88$
> 
> cristian@cristian-HP-240-G7-Notebook-PC:~/Downloads/realtek_drivers/rtw88$ ls
> bf.c             debug.o         mac80211.o    phy.c
> rtw8723de.h       rtw8821c_table.c  rtw8822ce.c          sec.c
> bf.h             dkms.conf       mac.c         phy.h
> rtw8723d_fw.bin   rtw8821c_table.h  rtw8822ce.h          sec.h
> bitfield.h       efuse.c         mac.h         ps.c         rtw8723d.h
>         rtw8822b.c        rtw8822c_fw.bin      sign-file
> certificate.p12  efuse.h         main.c        ps.h
> rtw8723d_table.c  rtw8822be.c       rtw8822c.h           tx.c
> certificate.pem  fw.c            main.h        README.md
> rtw8723d_table.h  rtw8822be.h       rtw8822c_table.c     tx.h
> coex.c           fw.h            main.o        regd.c       rtw8821c.c
>         rtw8822b_fw.bin   rtw8822c_table.h     util.c
> coex.h           hci.h           Makefile      regd.h
> rtw8821ce.c       rtw8822b.h        rtw8822c_wow_fw.bin  util.h
> compiler.h       kernel_key.pem  openssl.conf  reg.h
> rtw8821ce.h       rtw8822b_table.c  rx.c                 util.o
> debug.c          key.pem         pci.c         rtw8723d.c
> rtw8821c_fw.bin   rtw8822b_table.h  rx.h                 wow.c
> debug.h          mac80211.c      pci.h         rtw8723de.c  rtw8821c.h
>         rtw8822c.c        sch_generic.h        wow.h
> 
> cristian@cristian-HP-240-G7-Notebook-PC:~/Downloads/realtek_drivers/rtw88$ make
> make -C /lib/modules/5.4.0-42-generic/build
> M=/home/cristian/Downloads/realtek_drivers/rtw88 modules
> make1: Entering directory '/usr/src/linux-headers-5.4.0-42-generic'
>    CC M  /home/cristian/Downloads/realtek_drivers/rtw88/main.o
> /home/cristian/Downloads/realtek_drivers/rtw88/main.c: In function
> rtw_core_init:
> /home/cristian/Downloads/realtek_drivers/rtw88/main.c:1623:2: error:
> implicit declaration of function tasklet_setup
> -Werror=implicit-function-declaration
>   1623   tasklet_setup(&rtwdev->tx_tasklet, rtw_tx_tasklet);
> 
> cc1: some warnings being treated as errors
> make2: *** scripts/Makefile.build:275:
> /home/cristian/Downloads/realtek_drivers/rtw88/main.o Error 1
> make1: *** Makefile:1731: /home/cristian/Downloads/realtek_drivers/rtw88 Error 2
> make1: Leaving directory '/usr/src/linux-headers-5.4.0-42-generic'
> make: *** Makefile:79: all Error 2
> 
> cristian@cristian-HP-240-G7-Notebook-PC:~/Downloads/realtek_drivers/rtw88$
> sudo make install
> sudo password for cristian:
> make -C /lib/modules/5.4.0-42-generic/build
> M=/home/cristian/Downloads/realtek_drivers/rtw88 modules
> make1: Entering directory '/usr/src/linux-headers-5.4.0-42-generic'
>    CC M  /home/cristian/Downloads/realtek_drivers/rtw88/main.o
> /home/cristian/Downloads/realtek_drivers/rtw88/main.c: In function
> rtw_core_init:
> /home/cristian/Downloads/realtek_drivers/rtw88/main.c:1623:2: error:
> implicit declaration of function tasklet_setup
> -Werror=implicit-function-declaration
>   1623 |  tasklet_setup(&rtwdev->tx_tasklet, rtw_tx_tasklet);
> 
> cc1: some warnings being treated as errors
> make2: *** scripts/Makefile.build:275:
> /home/cristian/Downloads/realtek_drivers/rtw88/main.o Error 1
> make1: *** Makefile:1731: /home/cristian/Downloads/realtek_drivers/rtw88 Error 2
> make1: Leaving directory '/usr/src/linux-headers-5.4.0-42-generic'
> make: *** Makefile:79: all Error 2
> 
> cristian@cristian-HP-240-G7-Notebook-PC:~/Downloads/realtek_drivers/rtw88$
> 
> 
> ===========

You need to do a git pull. The missing tasklet_setup was fixed on Sep. 26.

Larry